Comments (1)
newville
commented on July 27, 2024
Ugh, SAVE statements are the yuck. But it looks like maybe iscmt .eq. 1 is used to signal "first time called" to fill the saved arrays, so that rhoold is never actually used uninitialized (but starts out as edenvl (which is clearly short for "Eden Valhalla". iscmt most likely means "Index of Self-Consistent Muffin-Tin" but I read as "Is Computed Tomography". Yes, there are too many TLA and even too many sxchvn [six character-long variable names]). Anyway, since iscmt is simply incremented (starting at 1) in pot.f, it looks like maybe this is ugly, but actually never uses uninitialized values.
It might be worth considering pulling out the saved arrays (ri05, wt, etc) into scmt.f and scmtmp.f and passing them in, just to avoid the SAVE statement. Well, "consider" doing that. SAVE is not pure evil like COMMON, but we should view them with suspicion.
from feff85exafs.
Related Issues (20)
- EXCH/mpse.f is broken HOT 5
- parallel compilation is currently not an option HOT 2
- MATH/polint.f compiles with an odd warning HOT 1
- unit test coverage
- branches HOT 3
- small error in calculation of mag[feff]
- ints vs long on 64-bit HOT 6
- k-grid in feffNNNN.dat HOT 1
- cleanup in wrapper folder
- fixdsp.f --- setting grid
- promotion of single to double HOT 2
- build fails on OS X HOT 3
- fundamental constants should be updated HOT 5
- names of "module binaries" do not convey "feff8l"-ness HOT 2
- need a test suite! HOT 1
- main Python script is Python2 only HOT 1
- perform static analysis HOT 2
- need to get rid of ".bin" extensions HOT 3
- Compilation with -finit-local-zero fails HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feff85exafs.