Downloading empty file

[xxcodianxx]

Downloading empty file

[xxcodianxx]

bestaudio+bestvideo also seems to work with this change, make sure to urlescape + properly as %2B

Committed some extra stuff, but 75e0b3d should fix it. Let me know how it goes.

[DavidBerdik]

@xxcodianxx I am encountering the same issue on my stripped-down fork of this project. If time permits and I find a solution before you get to it, I will let you know.

[cryptopsy30]

Thanks @xxcodianxx the patch fixed it for me. The video I was testing with was D5vqvPaMCLg.

It is now downloading the file in .webm. Would it be possible to add the option to download in more format such as .mp3 when selecting audio only?

Thank you for your effort. I love this project.

[DavidBerdik]

bestaudio+bestvideo also seems to work with this change, make sure to urlescape + properly as %2B

Committed some extra stuff, but 75e0b3d should fix it. Let me know how it goes.

@xxcodianxx Ah yes! That was it! I can't believe I forgot about that. I should know better. Anyway, it seems to be working for me as well.

[xxcodianxx]

It may be because I'm properly setting the content-disposition header now.

This is probably somehow related to d7f76fd

[xxcodianxx]

Going to investigate this, thanks for the issue.

[xxcodianxx]

I can't seem to reproduce this bug locally on the provided Docker containers, everything downloads fine, but I can obviously see this is a real issue...

@cryptopsy30 Can you provide a link to an example video that doesn't download properly? The problem may be localized to only some videos/edge cases.
@DavidBerdik Thanks for your help!

[DavidBerdik]

@xxcodianxx You're welcome! The issue seems to be caused by yt-dlp version 2022.08.19. I've been able to get the dl endpoint working for best, bestaudio, and bestvideo, but it's still broken for bestvideo+bestaudio.

The changes I made to get it working are in my repo here. I should note that the ffmpeg flag change was not something I tested. I did it before realizing that it was not yt-dlp.

[xxcodianxx]

Glad that it works! As for reformatting into mp3, well it's complicated.

Right now I'm returning the exact thing youtube sends over, in the container that requires least transcoding.

If you hover over the different audio options, you'll notice some are mp4a. These download as mp4 files, but I may be able to make them into mp3's without sacrificing speed.

Marking this issue as closed, thanks everyone!

[DavidBerdik]

@xxcodianxx Even though it's working for me, I do have a question: I noticed that after the changes you made, hitting the dl endpoint with a browser no longer results in in-browser playback. Instead, the stream starts downloading. What is the reason for this change?

[DavidBerdik]

@xxcodianxx Got it. Thank you!