Test with graphql-js v15.0.0-rc.2

[yaacovcr]

Test with graphql-js v15.0.0-rc.2

[yaacovCR]

Yes! Congrats!

Hopefully over the next few days will update branch.

[IvanGoncharov]

@yaacovCR Sounds great 👍 I already promised that it will be the last batch of breaking changes so if everything goes smooth next release would be 15.0.0.

[yaacovCR]

released as [email protected] a bit prematurely, some failing tests, but two are related to the order the schema is printed i believe not matching test expectation, known breaking change/improvement.

Last one I am not so sure.

There were additional linting changes.

Also graphql-tools upstream will need to be updated to refer to printSchema.js instead of SchemaPrinter when it reaches into internal export

But looks ok!!

[yaacovCR]

You can install support for v15 rc2 with:

npm install [email protected]

[yaacovCR]

bb02f68

[yaacovCR]

@IvanGoncharov , FYI I also had to remove node 8 support only this go around. I see no longer supported in graphql-js, but was working anyway in rc1.

In rc2, all subscription stuff failed with v8. Having said that, I am not sure that rc2 itself required removing v8 support, as I also did a fresh install and possibly another dependency received a minor update that broke it

[yaacovCR]

@IvanGoncharov

More careful review of above shows that change in
graphql/graphql-js@23b427c#diff-824b72afd8ba7cd9703ec9cf944ab81a

causes TypeScript to be unable to parse the return type of getNullableType when passing in a parameter of type GraphQLType.

This can be fixed, I think, by changing the definition of:

export type GraphQLType =
  | GraphQLScalarType
  | GraphQLObjectType
  | GraphQLInterfaceType
  | GraphQLUnionType
  | GraphQLEnumType
  | GraphQLInputObjectType
// from:
//  | GraphQLList<any>
//  | GraphQLNonNull<any>;
// to:
  | GraphQLList<GraphQLType>
  | GraphQLNonNull<GraphQLType>;

Parallel changes can be made elsewhere, for example:

export type GraphQLNullableType =
  | GraphQLScalarType
  | GraphQLObjectType
  | GraphQLInterfaceType
  | GraphQLUnionType
  | GraphQLEnumType
  | GraphQLInputObjectType
//  from:
//  | GraphQLList<any>;
//  to:
  | GraphQLList<GraphQLType>;

[yaacovCR]

I am also able to make this change on my version of TypeScript:

export type GraphQLOutputType =
  | GraphQLScalarType
  | GraphQLObjectType
  | GraphQLInterfaceType
  | GraphQLUnionType
  | GraphQLEnumType
// ADD:
//  | GraphQLList<GraphQLOutputType>
//  | GraphQLNonNull<GraphQLOutputType>;
// REMOVE:
//  | GraphQLList<any>
//  | GraphQLNonNull<
//      | GraphQLScalarType
//      | GraphQLObjectType
//      | GraphQLInterfaceType
//      | GraphQLUnionType
//      | GraphQLEnumType
//      | GraphQLList<any>
//    >;

Comment above that portion of code notwithstanding, looking like TypeScript is allowing recursive type definitions...

[yaacovCR]

Released support in v8.6.0.

[IvanGoncharov]

@yaacovCR Thanks for the investigation 👍
Sadly changes that you proposed breaks pre-3.7 TS versions:

So simplest solution would be to partially revert graphql/graphql-js@23b427c#diff-824b72afd8ba7cd9703ec9cf944ab81a

Long term plan: After TS rewrite we can increase minimal supported version to 3.4 and use https://github.com/sandersn/downlevel-dts

[yaacovCR]

Gotcha.