Giter Site home page Giter Site logo

Comments (8)

YahnisElsts avatar YahnisElsts commented on June 11, 2024

No, probably not.

It doesn't seem useful enough to be worth the effort. This isn't a JS library that has to be downloaded by every visitor. It just sits on the server. I think going to great lengths to reduce the size wouldn't yield much of a benefit.

from plugin-update-checker.

mehdi-najaran avatar mehdi-najaran commented on June 11, 2024

Now I put the project file in my plugin core

This issue has increased its volume, am I wrong?

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 11, 2024

You are not wrong. By adding PUC to your plugin, the size of your plugin download has increased by about 150 KB (zipped).

But what is the meaningful impact of that? Your users will have to spend a fraction of a second longer downloading your plugin, and it will take up about 360 KB more space on their server. Will they even notice? How much does that matter, and how much time are you willing to spend to optimize it? Personally, it doesn't look very significant to me.

(I'm aware that this sounds suspiciously similar to the kind of reasoning that some careless people might use to justify e.g. websites adding megabytes of JS to every page, but I think scale does matter here. Installing a plugin is generally a one-time kind of thing, or close to that.)

from plugin-update-checker.

mehdi-najaran avatar mehdi-najaran commented on June 11, 2024

Yes you are right .
But keep this issue that I have raised as an idea and suggestion in the corner of your mind, and implement it whenever you can.

Because, for example, my plugin is 80 kilobytes in size and is highly optimized. If a 150 KB project is added to it, it will really stand out

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 11, 2024

All right.

from plugin-update-checker.

DavidAnderson684 avatar DavidAnderson684 commented on June 11, 2024

Removing parts of a project can be unexpectedly dangerous: if multiple plugins are using this library, and the one that gets loaded is a version with some classes removed, then that may cause the plugins that expected the full version to be present to have a problem.

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 11, 2024

That is also a good point, and one that didn't occur to me. Though to be fair, it would be possible to redesign the library to still work correctly in that situation - it would just take even more work.

from plugin-update-checker.

theo-gk avatar theo-gk commented on June 11, 2024

@mehdi-najaran You can safely remove the translation files from the /languages/ directory in case you don't need them. It will save you more than 80KB. But it will have no effect in performance, just in file size. Probably isn't worth it, though.

from plugin-update-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.