Giter Site home page Giter Site logo

Comments (6)

BinTianqi avatar BinTianqi commented on May 16, 2024 1

I built the code in this branch: https://github.com/SomeTroglodyte/Unciv/tree/PolicyPickerSkinnable , added PolicyColors.zip mod (in PR #11050) to the game , and ran the game with no problem.
studio64_pmwlNYW952
I'm trying to follow the PR's instructions and modify the policy picker screen.

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 16, 2024

There's nothing to say

Curse we all live with...

But - I believe there was code to highlight. At least when you do have points or a freebie to adopt a new one, it highlights adoptable ones? No?

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 16, 2024

The code in question is here. As I said, selection only changes visuals for pickable policies.

To improve -

  • Round off PolicyColors: Include all six possible states per button, not only three. Maybe other hardcoded colors too.
  • Make the entire thing skinnable. Doing so using Skin.json I would remember how - nah better our skin stuff from #7804.
  • With that patch in, ask someone with taste to tweak a Skin mod until it's pleasant, then adopt these colors as default?

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 16, 2024

@BinTianqi if you can run unreleased code, you might help out? See the linked PR - I could supply a jar and/or apk1 for that branch, and then you could follow the PR's instructions and start modding the policy picker screen...

Footnotes

  1. debug apk's are debug-signed and therefore incompatible with any non-debug release - switching needs an uninstall with data loss. As is usual in the Android world.

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 16, 2024

Well, did you arrive at a styling that would be better as default for everybody?

from unciv.

BinTianqi avatar BinTianqi commented on May 16, 2024

This is too difficult for me.

I set a noticeable color in PolicyColors.json and PolicyColorsDefault.json

ResizedImage_2024-03-06_18-24-26_1346.png

But no effect

ResizedImage_2024-03-06_18-16-57_3172.png

(Android14, Unciv 4.10.16)

from unciv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.