Wiki page sections with the same name are not linked correctly

[yakivmospan]

Wiki page sections with the same name are not linked correctly

[yakivmospan]

Hey guys, thanks for your contribution. Will try to get into these issues as soon as possible. Pull requests are always welcomed here.

[pbaret]

Is it similar to the issue I raised here : #42

I proposed a quickfix

[HayDegha0917]

Similar but not the same. If I understand your fix, it also has a bug, because you are assuming that the heading titles are always going to be unique. Instead of stripping the file name, you should add the name to the anchor references and modify all anchors to be "fully qualified" by adding the name of the original file to the anchor name. Thanks, Ara

…

________________________________ From: Pierre Baret <[email protected]> Sent: Wednesday, August 28, 2019 1:37:55 AM To: yakivmospan/github-wikito-converter <[email protected]> Cc: HayDegha0917 <[email protected]>; Author <[email protected]> Subject: Re: [yakivmospan/github-wikito-converter] Wiki page sections with the same name are not linked correctly (#45) Is it similar to the issue I raised here : #42<#42> I proposed a quickfix — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#45?email_source=notifications&email_token=AFCEJ5DVY6OLNZ3TU6NZYFLQGY2OHA5CNFSM4H3KXC72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KK43I#issuecomment-525643373>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFCEJ5AWH337EHNUDMAZE43QGY2OHANCNFSM4H3KXC7Q>.

[pbaret]

Like I say in my comment on issue #42, I am not a confortable js developper, I just found out how to make things work as expected locally on my machine. I would prefer you or a confirmed js dev to check that out.

@HayDegha0917 yes you right, I assume the id to be unique in my quick fix because it made me dig into only one place of the code where link are created. otherwise it would require to change both the html id creation and the html href.

[danielburrell]

Similar issue here, I have files with the same titles because they were originally in different directory structures (gitlab wiki). When the html page is rendered you end up with dual links as above which breaks the navigation pane.