Giter Site home page Giter Site logo

Comments (5)

yangheng95 avatar yangheng95 commented on May 14, 2024

Thanks for reporting this, the text_right is not used in the BERT-based models, it was used in some models relying on left and right contexts. And this inferring script has not been tested on those non-BERT-based models. I will fix some problems later.

The truncating of sentences is useful in low resources systems, If you use large max_len, it may help, however not very apparent.

Actually, it is difficult to integrate multilingual datasets and multiple models, I have not much time to test new code. Again, sorry for causing your inconvenience.

from pyabsa.

yangheng95 avatar yangheng95 commented on May 14, 2024

Please check here https://github.com/yangheng95/LC-ABSA/blob/dc27f9b09607e8125c49de9b00cd508a21b9b75a/modules/utils/data_utils_for_inferring.py#L276

from pyabsa.

tusharkgerg avatar tusharkgerg commented on May 14, 2024

thanks @yangheng95 that was helpful!

from pyabsa.

yangheng95 avatar yangheng95 commented on May 14, 2024

thanks @yangheng95 that was helpful!

I am sorry that you may check the code again, I update the code because I ignored some cases that aspect is at the beginning or ending.

from pyabsa.

tusharkgerg avatar tusharkgerg commented on May 14, 2024

@yangheng95 I just ran the code. Seems to have fixed the truncation problem where aspect was in the beginning! :) Awesome Stuff 👍
Also would be great to discuss how I am approaching the problem by using your model implementation.. In case you may have some spare time :p For reassurance.

from pyabsa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.