Giter Site home page Giter Site logo

Comments (2)

ziogaschr avatar ziogaschr commented on July 20, 2024

This is correct. Although I think the intention of @yankodimitrov was to leave this implementation detail to the implementors.

There are many reasons for doing this. Think of an app that requires this key to be stored in Keychain and also to be fully encrypted when phone is locked.
You can always argue that this request doesn't expose any risk, but some apps might need to follow some privacy rules, that storing this value will limit them.

There are many such modules that can fit perfect to this project as additional plugins.
Examples are:

  • Store PIN to Keychain
  • Store PIN to NSUserDefaults
  • Store maximum attempts limit reached...
  • Add PIN time expiry
  • Add auto-handling of showing the PIN Lock view when app moves to foreground
  • Add Splash view
  • Add themes for .xib

That way someone can use only what he needs for his project easily.
It will be nice if we can make a call altogether and go this awesome project a step further.

from swiftpasscodelock.

le4ker avatar le4ker commented on July 20, 2024

This is correct. Although I think the intention of @yankodimitrov was to leave this implementation detail to the implementors.

It's not mentioned in the readme file, which makes it dangerous 😞 Also, how can you implement the persisted behavior to this member since it's private?

It will be nice if we can make a call altogether and go this awesome project a step further.

Totally agree on that! And we can start by mentioning this behavior in the readme file.

from swiftpasscodelock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.