Segfault during configuration when calling ngx_http_conf_upstream_srv_conf()

[yaoweibin]

Segfault during configuration when calling ngx_http_conf_upstream_srv_conf()

[yaoweibin]

Thanks for your bug report, nice catch. I have fixed the problem in the new revision.
You may need a addition patch with your nginx_upstream_hash module. See the round robin as an example.

[mtourne]

It still segv, I also suggest adding in ngx_http_check_add_peer() :

@@ -158,7 +158,11 @@
ngx_http_check_peer_t *peer;
ngx_http_check_peers_t *peers;
ngx_http_upstream_check_srv_conf_t *ucscf;

• ngx_http_upstream_check_main_conf_t *ucmcf;
• ngx_http_upstream_check_main_conf_t *ucmcf;

• if (us->srv_conf == NULL) {

•    return NGX_ERROR;
  

• }

ucscf = ngx_http_conf_upstream_srv_conf(us, ngx_http_upstream_check_module);

[yaoweibin]

OK, I have fixed it. Thanks again.

If you don't mind, I want to invite you to commit the module. And you will be a collaborator in the README file. You are an excellent Nginx user and developer.