check_status conflicts with check_status from https://github.com/yaoweibin/nginx_tcp_proxy_module

[yaoweibin]

check_status conflicts with check_status from https://github.com/yaoweibin/nginx_tcp_proxy_module

[yaoweibin]

The directive in tcp_proxy module has been renamed to be tcp_check_status,
can't work?

2015-02-25 14:25 GMT+08:00 Cosnita Radu Viorel [email protected]:

By default there is no way to activate status page for both
https://github.com/yaoweibin/nginx_tcp_proxy_module and
nginx_upstream_check_module. It would be nice if check_status for this
module would be more specific: healthcheck_status.

—
Reply to this email directly or view it on GitHub
#50.

[rcosnita]

Indeed the tcp_check_status is the directive which does not generate a warning. Unfortunately, check_status is supported as well in tcp_proxy_module but it gives a deprecated warning and a recommendation to use tcp_check_status instead.

I did not have time to deep dive into tcp_proxy_module code. Instead I made a minor change in nginx upstream health check module so that it uses healthcheck_status directive instead of check_status for activating status page.

I am using both modules under nginx 1.7.4.1. Thank you so much for your excellent work.

[rcosnita]

I investigated tcp_proxy_module code and the conflict comes from https://github.com/irr/nginx_tcp_proxy_module/blob/master/ngx_tcp_upstream_check.c:174.

[yaoweibin]

Yes. If I remove the check_status directive in the tcp proxy module, It may break many other users, so I just want keep it this year.

Thank you.

在 2015年2月27日，下午3:05，Cosnita Radu Viorel [email protected] 写道：

I investigated tcp_proxy_module code and the conflict comes from https://github.com/irr/nginx_tcp_proxy_module/blob/master/ngx_tcp_upstream_check.c:174 https://github.com/irr/nginx_tcp_proxy_module/blob/master/ngx_tcp_upstream_check.c:174.

—
Reply to this email directly or view it on GitHub #50 (comment).