Improvement request: Check status page to show hostnames instead of IP addresses

[yaoweibin]

Improvement request: Check status page to show hostnames instead of IP addresses

[yaoweibin]

On 2011-7-8 8:58, adamdamico wrote:

In the config, we specify upstreams as hostnames, but on the check status page, what's shown is the corresponding IP address. This is true even if a PTR record exists in DNS.

Running in a public cloud, IP addresses are meaningless/random, so it would be very helpful if that page showed what was in the config file instead of what gets resolved.
I could add the upstream name in this page for each server quickly. Is
that fit you? Like this:

+--------------------------------------------------------------------------------------------------------------------+
| Index | Upstream | Name | Status | Business | Rise
counts | Fall counts | Access counts | Check type |
|-------+----------+--------------------+--------+----------+-------------+-------------+---------------+------------|
| 0 | test | 127.0.0.1:81 | down | 0 |
0 | 1 | 0 | http |
|-------+----------+--------------------+--------+----------+-------------+-------------+---------------+------------|
| 1 | test | 127.0.0.1:82 | down | 0 |
0 | 1 | 0 | http |
|-------+----------+--------------------+--------+----------+-------------+-------------+---------------+------------|
| 2 | test | 127.0.0.1:80 | up | 0 |
3 | 0 | 0 | http |
|-------+----------+--------------------+--------+----------+-------------+-------------+---------------+------------|
| 3 | blog | 220.181.31.179:80 | up | 0 |
2 | 0 | 0 | http |
|-------+----------+--------------------+--------+----------+-------------+-------------+---------------+------------|
| 4 | blog | 220.181.31.180:80 | up | 0 |
2 | 0 | 0 | http |
+--------------------------------------------------------------------------------------------------------------------+

If you really need the host name, I could add it. But the patch will be
changed.

Weibin Yao

[adamdamico]

Yes, even better!

[yaoweibin]

On 2011-7-8 10:53, adamdamico wrote:

Yes, even better!
OK, try the latest revision, Hope you like it.

Weibin Yao

[adamdamico]

Thank you!

[adamdamico]

I built this and took a look. I misunderstood what you wrote above. I see the name from the upstream directive in my nginx.conf, but it still doesn't show me the names of the member servers. What I'm hoping for is not to have to look up an IP address in order to see which upstream node is which.

Since I only have one upstream directive, this doesn't provide any new info.

[yaoweibin]

Hi Adam,

OK, try this branch:
https://github.com/yaoweibin/nginx_upstream_check_module/tree/for_adam .

I modified the source of Nginx for fitting your need. This module's
patch is changed. You should patch Nginx again. I will not merge this
branch to the master branch.

BTW: The reload problem should be fixed in the master and this branch.
If there is still any problem, let me know.

Thanks.

On 2011-7-12 7:04, adamdamico wrote:

I built this and took a look. I misunderstood what you wrote above. I see the name from the upstream directive in my nginx.conf, but it still doesn't show me the names of the member servers. What I'm hoping for is not to have to look up an IP address in order to see which upstream node is which.

Since I only have one upstream directive, this doesn't provide any new info.

Weibin Yao

[adamdamico]

Thank you very much, will try it today.

Curious, what's keeping you from merging it with master?

[yaoweibin]

On 2011-7-13 3:58, adamdamico wrote:

Thank you very much, will try it today.

Curious, what's keeping you from merging it with master?
I just want to change the source of Nginx as little as possible.

Weibin Yao

[adamdamico]

Understood. This does exactly what I need, thank you.