Comments (7)
This issue is assigned toy you @adarsh1001111
Acceptance criteria:
- Nav bar should be visible to in chat section.
- chat screen should be rendered without any UI issue after login.
- Leaderboard and chat option should be visible to unauthenticated user as well
Testing Scope:
- Create two testing accounts and test chat section by dummy chat. provide screen recording with PR.
Ask doubts on this thread if you have any.
from crazycoderwebapp.
'Footer' and 'Navbar' , both dissaperar at "/chat" route.
Becouse this is how code is written.
If no PRs yet, then i would like to contribute to this.
Also, Please state specefically which would be needed at "/chat" route i.e
- Navbar
- Footer
- or Both
from crazycoderwebapp.
'Footer' and 'Navbar' , both dissaperar at "/chat" route. Becouse this is how code is written.
If no PRs yet, then i would like to contribute to this. Also, Please state specefically which would be needed at "/chat" route i.e
- Navbar
- Footer
- or Both
Thanks for volunteering , since there were no clear instructions in the readme file about setting the project up using vite+react it took a little time but m working on this one ! Thank You
from crazycoderwebapp.
![Screenshot 2024-05-13 at 9 21 10 AM](https://private-user-images.githubusercontent.com/130575709/329916771-64dda3ff-076c-4188-a95c-264e69cf10b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTcyNTA5MjUsIm5iZiI6MTcxNzI1MDYyNSwicGF0aCI6Ii8xMzA1NzU3MDkvMzI5OTE2NzcxLTY0ZGRhM2ZmLTA3NmMtNDE4OC1hOTVjLTI2NGU2OWNmMTBiMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYwMVQxNDAzNDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNjk2MTM1OWZiZWY2NTU3ZWNiMjY1ODFhZDM0M2NkZWViMzk3MGYzOWE4ZDdmYjM5MjdhNzAwY2ViZGZjNTBmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7GRAzSfOeOrkjdrzZ1iMU-m-AmHXUw8haGRFcZeq-cg)
@Yash-Parsana
I fixed the bug but ,
Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that.
Also can u specify how to test the app using chat elaborately with setup and files .
![Screenshot 2024-05-12 at 11 52 58 PM](https://private-user-images.githubusercontent.com/130575709/329871936-ff6b703d-9c9e-4354-84b1-201bff26d927.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTcyNTA5MjUsIm5iZiI6MTcxNzI1MDYyNSwicGF0aCI6Ii8xMzA1NzU3MDkvMzI5ODcxOTM2LWZmNmI3MDNkLTljOWUtNDM1NC04NGIxLTIwMWJmZjI2ZDkyNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYwMVQxNDAzNDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMjIwM2ZmNDUxN2Y1MTE3ZWU3YWUxMWQ3MTJjMjgwMjAzZjY0NmIxYmYwNzY0Yjg0MGUxYTQ3MTU1MzRlNWE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.4ttOydREHP2LsVz32yrGQd0x-J1hRH8_n4pUy3LdP6M)
from crazycoderwebapp.
@Yash-Parsana I fixed the bug but , Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that. Also can u specify how to test the app using chat elaborately with setup and files .
![]()
It would be better if you delete the if-else block , And simply do return statement once.
from crazycoderwebapp.
@Yash-Parsana I fixed the bug but , Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that. Also can u specify how to test the app using chat elaborately with setup and files .
![]()
It would be better if you delete the if-else block , And simply do return statement once.
I already wrote in my PR that i kept the if else block for the ease to debug any issue created by my edit(cause i was not able to test it) please go through the PR @MishraTanishq619
from crazycoderwebapp.
@adarsh1001111 keeping header and footer in chat page same as other pages was causing ui related issues in main chat screen so as temporary fix i had removed them by if condition but it is not good practice so we should fix it now. you have to solve that ui bug in chat screen.
i have provided firbase config file now you can use it to test chat screen. Create real chat scenario by using two dummy users.
and yes we want both header and footer in chat page.
And i am adding steps to run project in readme file.
from crazycoderwebapp.
Related Issues (20)
- Bug: Header in chat section is not visible
- "Chat " Page lacks Header and Footer. HOT 2
- Adding hover effect to the footer
- Color Palette Adjustment: Improve User Experience
- Add GitHub Desktop Contribution Instructions
- Auto Commenting when a PR is merged
- Feature for auto commenting on a new issue creation
- Auto commenting feature for new PR raised
- add visible and hide password in password session btn HOT 1
- Fix sign in and login page HOT 1
- auto comment on an issue and self assign
- Go to home page on Clicking at Crazy Coder HOT 1
- 💡[FEATURE]: I can help In making a the responsive design of the webpage more cooler and with better User experience
- 🪲[Bug]: Confirm Password not hidden during signup HOT 1
- 💡[FEATURE]: 404 page not found page devlop HOT 1
- 💡[FEATURE]: Add some hover effect on navbar links HOT 2
- Sign in page HOT 3
- 💡[FEATURE]: Create Issue forms and make the issue options more visually appealing HOT 1
- 💡[FEATURE]: Adding scroll back to top button. HOT 2
- 💡[FEATURE]: Profile Page not showing user details HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crazycoderwebapp.