Giter Site home page Giter Site logo

Comments (7)

Yash-Parsana avatar Yash-Parsana commented on August 17, 2024 1

This issue is assigned toy you @adarsh1001111

Acceptance criteria:

  • Nav bar should be visible to in chat section.
  • chat screen should be rendered without any UI issue after login.
  • Leaderboard and chat option should be visible to unauthenticated user as well

Testing Scope:

  • Create two testing accounts and test chat section by dummy chat. provide screen recording with PR.

Ask doubts on this thread if you have any.

from crazycoderwebapp.

MishraTanishq619 avatar MishraTanishq619 commented on August 17, 2024

'Footer' and 'Navbar' , both dissaperar at "/chat" route.
Becouse this is how code is written.

If no PRs yet, then i would like to contribute to this.
Also, Please state specefically which would be needed at "/chat" route i.e

  • Navbar
  • Footer
  • or Both

from crazycoderwebapp.

adarsh1001111 avatar adarsh1001111 commented on August 17, 2024

'Footer' and 'Navbar' , both dissaperar at "/chat" route. Becouse this is how code is written.

If no PRs yet, then i would like to contribute to this. Also, Please state specefically which would be needed at "/chat" route i.e

  • Navbar
  • Footer
  • or Both

Thanks for volunteering , since there were no clear instructions in the readme file about setting the project up using vite+react it took a little time but m working on this one ! Thank You

from crazycoderwebapp.

adarsh1001111 avatar adarsh1001111 commented on August 17, 2024
Screenshot 2024-05-13 at 9 21 10 AM

@Yash-Parsana
I fixed the bug but ,
Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that.
Also can u specify how to test the app using chat elaborately with setup and files .

Screenshot 2024-05-12 at 11 52 58 PM

from crazycoderwebapp.

MishraTanishq619 avatar MishraTanishq619 commented on August 17, 2024
Screenshot 2024-05-13 at 9 21 10 AM @Yash-Parsana I fixed the bug but , Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that. Also can u specify how to test the app using chat elaborately with setup and files . Screenshot 2024-05-12 at 11 52 58 PM

It would be better if you delete the if-else block , And simply do return statement once.

from crazycoderwebapp.

adarsh1001111 avatar adarsh1001111 commented on August 17, 2024
Screenshot 2024-05-13 at 9 21 10 AM @Yash-Parsana I fixed the bug but , Can i ask why there is an if block for /chat route specifically in "App.jsx" without headers and footers (in the pic i added them and the page is fixed), maybe some bug/feature which was fixed by doing that. Also can u specify how to test the app using chat elaborately with setup and files . Screenshot 2024-05-12 at 11 52 58 PM

It would be better if you delete the if-else block , And simply do return statement once.

I already wrote in my PR that i kept the if else block for the ease to debug any issue created by my edit(cause i was not able to test it) please go through the PR @MishraTanishq619

from crazycoderwebapp.

Yash-Parsana avatar Yash-Parsana commented on August 17, 2024

@adarsh1001111 keeping header and footer in chat page same as other pages was causing ui related issues in main chat screen so as temporary fix i had removed them by if condition but it is not good practice so we should fix it now. you have to solve that ui bug in chat screen.
i have provided firbase config file now you can use it to test chat screen. Create real chat scenario by using two dummy users.
and yes we want both header and footer in chat page.
And i am adding steps to run project in readme file.

cc: @MishraTanishq619

from crazycoderwebapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.