Giter Site home page Giter Site logo

Comments (18)

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024 1

Ok, thanks this makes it quite clear.

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024 1

Check https://www.w3schools.com/howto/howto_js_topnav_responsive.asp , can you make all buttons appear in dropdown when user click the button?

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024 1

Only for buttons

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024 1

No need to worry.

Few Changes Required:-

  1. Options button should hide on desktop.
  2. Hovering over submenu should change background color (like buttons).
  3. Window should fully fit on mobile screen(without any scrollbars).

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024 1

Okay, if first two changes are done you can send a PR so i can investigate further.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

Can I work on this?

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024

Can I work on this?

Sure, keep me updated.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

I am not sure, I am finished yet, but it looks quite responsive. Can I have your feedback on the design? Should I host the branch I am working on, so it is easier for you to review the changes?

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024

@Kyaw-Min-lwin Share the screenshot here. I will follow up👍
Also i will check your forked repository from your profile if you want, no need to host.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

Ok @yashchaudhari008
Screenshot (156)
Would like your feedback.

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024

I am expecting something like this.
Also you can hide that instructions "q and a to change pen size" as they are mean only for PC users.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

Hey, how is this? @yashchaudhari008
Screenshot (157)

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

@yashchaudhari008 Should I make it so that all of the buttons, color selection box, and the pen size only show up when the user clicks a dropdown, or is it only for the buttons.

from drawit.

yashchaudhari008 avatar yashchaudhari008 commented on August 20, 2024

Also make sure that footer is visible and canvas is properly scaled on mobile displays.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

@yashchaudhari008

Also make sure that footer is visible and canvas is properly scaled on mobile displays.

The user needs to scroll down a little for them to see the footer.
Screenshot (158)
Screenshot (159)
What do you think of the dropdown? Also, can you help me with the color changer.? I would like the input to be in the related p tag so it looks nicer. Should I change the canvas height so that it fits in the screen and the user doesn't have to scroll.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

@yashchaudhari008 is there anyone working on this other than me. Should I be worried about the other issues(others r working on) will it affect me. Sry this is my first time contributing to open source.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

I have hidden the options button on desktop. I also added the hover(U need to either resize the browser or the inspect bar, using the toggle inspect toolbar doesn't show you the hover even on the color select thing.) I will need help with the third one. I can't use css because the browser is automatically applying the height n width to the canvas tag. This is probably due to the js.

from drawit.

Kyaw-Min-lwin avatar Kyaw-Min-lwin commented on August 20, 2024

@yashchaudhari008 I have made some changes, what do you think?

from drawit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.