Comments (18)
Ok, thanks this makes it quite clear.
from drawit.
Check https://www.w3schools.com/howto/howto_js_topnav_responsive.asp , can you make all buttons appear in dropdown when user click the button?
from drawit.
Only for buttons
from drawit.
No need to worry.
Few Changes Required:-
- Options button should hide on desktop.
- Hovering over submenu should change background color (like buttons).
- Window should fully fit on mobile screen(without any scrollbars).
from drawit.
Okay, if first two changes are done you can send a PR so i can investigate further.
from drawit.
Can I work on this?
from drawit.
Can I work on this?
Sure, keep me updated.
from drawit.
I am not sure, I am finished yet, but it looks quite responsive. Can I have your feedback on the design? Should I host the branch I am working on, so it is easier for you to review the changes?
from drawit.
@Kyaw-Min-lwin Share the screenshot here. I will follow up👍
Also i will check your forked repository from your profile if you want, no need to host.
from drawit.
Ok @yashchaudhari008
Would like your feedback.
from drawit.
I am expecting something like this.
Also you can hide that instructions "q and a to change pen size" as they are mean only for PC users.
from drawit.
Hey, how is this? @yashchaudhari008
from drawit.
@yashchaudhari008 Should I make it so that all of the buttons, color selection box, and the pen size only show up when the user clicks a dropdown, or is it only for the buttons.
from drawit.
Also make sure that footer is visible and canvas is properly scaled on mobile displays.
from drawit.
Also make sure that footer is visible and canvas is properly scaled on mobile displays.
The user needs to scroll down a little for them to see the footer.
What do you think of the dropdown? Also, can you help me with the color changer.? I would like the input to be in the related p tag so it looks nicer. Should I change the canvas height so that it fits in the screen and the user doesn't have to scroll.
from drawit.
@yashchaudhari008 is there anyone working on this other than me. Should I be worried about the other issues(others r working on) will it affect me. Sry this is my first time contributing to open source.
from drawit.
I have hidden the options button on desktop. I also added the hover(U need to either resize the browser or the inspect bar, using the toggle inspect toolbar doesn't show you the hover even on the color select thing.) I will need help with the third one. I can't use css because the browser is automatically applying the height n width to the canvas tag. This is probably due to the js.
from drawit.
@yashchaudhari008 I have made some changes, what do you think?
from drawit.
Related Issues (20)
- Improve HTML semantics
- Add Eraser button HOT 2
- Unwanted drawings on canvas
- Pen preview like toast message. HOT 3
- change pen size to eraser size on using eraser HOT 1
- Changing cursor icon to brush tip. HOT 7
- A11y Issues
- Add Drawing Preloader to the website for better User Experience HOT 1
- Improvment in README.
- Add Full Screen Feature HOT 1
- indicate max pen size an allow user easily input desired pen size from a list of sizes. HOT 1
- pen size HOT 1
- Changing background colour clears the canvas
- The year in footer should update automatically HOT 2
- resizing window issue HOT 1
- sentence in top left corner cut off in full size window HOT 1
- instruction on top right side is very close to "-" button HOT 1
- Adding Screenshots in README HOT 1
- add transition duration on hover HOT 2
- Add About Us section on home page HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drawit.