String appears as an empty element even when set to null

[Nikey646]

String appears as an empty element even when set to null

[axunonb]

Please provide a working code sample as we can't reproduce this behavior.
See #174 for a working example regarding serialization.

[Nikey646]

A .Net Fiddle that shows the result as well.

The first result is kind of as expected.

The second result however, I'm not sure if I'm using the Serializer.Options incorrectly, but it shouldn't be appearing from my understanding?

Expected output for the second one should be

<MyObj>
</MyObj>

or

<MyObj />

[Nikey646]

Please provide a working code sample as we can't reproduce this behavior. See #174 for a working example regarding serialization.

Upon comparing the difference between the code I was using and the code provided in #174, setting the serializer.Options.SerializationOptions after the creation of the serializer while allowed (Has a public setter), it's not respected.

When creating a new SerializerOptions in the constructor, it works as expected.

[Nikey646]

Changing the SerializerOptions after creating the instance of YAXSerializer has no effect. This, however, will work:

[Test]
public void DontSerializeNullObjects_Test()
{
    var serializer = new YAXSerializer(typeof(MyObj), new SerializerOptions {SerializationOptions = YAXSerializationOptions.DontSerializeNullObjects });
    //serializer.Options.SerializationOptions = YAXSerializationOptions.DontSerializeNullObjects;

    var empty = new MyObj { MyValue = "" };
    var nullVal = new MyObj { MyValue = null };

    var emptyRes = serializer.Serialize(empty);
    var nullRes = serializer.Serialize(nullVal);

    emptyRes.Should().Contain("MyValue");
    nullRes.Should().NotContain("MyValue");
}

That`s why we're asking for a working code sample ;-)

I didn't realize that it would have been because applying the settings after creating the serializer would be the issue, hence why I didn't provide a code example.

In 4.x, or even potentially risking a breaking change in 3.x, and making the setters private for those? And only accepting the values from the constructor, with all arguments being optional?

[axunonb]

Changing the SerializerOptions after creating the instance of YAXSerializer has no effect.
This, however, will work:

[Test]
public void DontSerializeNullObjects_Test()
{
    var serializer = new YAXSerializer(typeof(MyObj), new SerializerOptions {SerializationOptions = YAXSerializationOptions.DontSerializeNullObjects });
    //serializer.Options.SerializationOptions = YAXSerializationOptions.DontSerializeNullObjects;

    var empty = new MyObj { MyValue = "" };
    var nullVal = new MyObj { MyValue = null };

    var emptyRes = serializer.Serialize(empty);
    var nullRes = serializer.Serialize(nullVal);

    emptyRes.Should().Contain("MyValue");
    nullRes.Should().NotContain("MyValue");
}

That`s why we're asking for a working code sample ;-)