Giter Site home page Giter Site logo

Comments (8)

sindresorhus avatar sindresorhus commented on May 18, 2024 3

It's in the options as it's not the main way to use this module. Ideally, it would support promises too. I think that would be a better change.

from update-notifier.

sindresorhus avatar sindresorhus commented on May 18, 2024 2

Actually, I think we should just deprecate the callback option and add a updateNotifier.check() method that returns a Promise for the update.

from update-notifier.

IssueHuntBot avatar IssueHuntBot commented on May 18, 2024

@IssueHunt has funded $40.00 to this issue.


from update-notifier.

LitoMore avatar LitoMore commented on May 18, 2024

I have already solved this issue in the #151.

from update-notifier.

LitoMore avatar LitoMore commented on May 18, 2024

We can use the updateNotifier.checkNpm() to get the version info, and it has already refactored to Promise.

from update-notifier.

LitoMore avatar LitoMore commented on May 18, 2024

I will make a new pull request to deprecate the callback option.

from update-notifier.

sindresorhus avatar sindresorhus commented on May 18, 2024

Fixed by #158

from update-notifier.

issuehunt-oss avatar issuehunt-oss commented on May 18, 2024

@sindresorhus has rewarded $36.00 to @litomore. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

from update-notifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.