Giter Site home page Giter Site logo

Comments (13)

dynasource avatar dynasource commented on July 26, 2024 1

agree. It makes sense to make Yii::$app in resolveCallableDependencies customizable

from yii-core.

samdark avatar samdark commented on July 26, 2024 1

Yes. It's the same except https://www.yiiframework.com/news/177/yii-adopts-semver-since-version-3-0-0

from yii-core.

SamMousa avatar SamMousa commented on July 26, 2024

Any input, i'm happy to defend the proposal if anyone has an opinion :)

from yii-core.

samdark avatar samdark commented on July 26, 2024

It makes sense to me. @yiisoft/core-developers what do you think?

from yii-core.

samdark avatar samdark commented on July 26, 2024

Can't do so w/o breaking BC.

from yii-core.

SamMousa avatar SamMousa commented on July 26, 2024

Why not? Adding an optional argument is allowed right?

Anyway, I'm fine with pushing this to 2.1

from yii-core.

samdark avatar samdark commented on July 26, 2024

Why not? Adding an optional argument is allowed right?

Yes.

from yii-core.

SamMousa avatar SamMousa commented on July 26, 2024

@samdark for which version should I make a PR?

Or should this be closed since you're working on a new DI project that will change everything?

from yii-core.

samdark avatar samdark commented on July 26, 2024

I'm still unsure if we'll be able to use that DI library in 3.0.0 since it may change framework too much. Will get an answer in a few weeks (hopefully).

from yii-core.

SamMousa avatar SamMousa commented on July 26, 2024

So definitely not in 2.x. Should I make a PR for 2.0.x then?

from yii-core.

samdark avatar samdark commented on July 26, 2024

Enhancements aren't accepted into 2.0 so I think it should be 3.0 after we'll decide on DI.

from yii-core.

SamMousa avatar SamMousa commented on July 26, 2024

Ah, but won't there be a 2.1? Or we going to 3 immediately?

from yii-core.

samdark avatar samdark commented on July 26, 2024

Closing since implementation is too different now.

from yii-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.