Comments (8)
I would remove the login() step it. It will not affect existing apps and new projects will be safer after the change.
from yii2-app-advanced.
There is no problem in existing way. I would say better way is to not automatically log in the user. User can login only if password is provided (login form). Most of the web apps does not automatically log in the user. It just verifies the email address.
from yii2-app-advanced.
I think this really boils down to a personal preference. I'd leave the template as it is and as it have been functioning for years.
from yii2-app-advanced.
But it is a template that someone is supposed to adopt to his own need. One will want auto login and another not wanting it, can remove. Can you explain why is it a problem?
I think adding documentation should be enough as we cannot cater every possible use case
from yii2-app-advanced.
I will remove it and document it for those who want to login automatically. What do you think @yiisoft/core-developers
from yii2-app-advanced.
from yii2-app-advanced.
I think this really boils down to a personal preference. I'd leave the template as it is
In this case we should put a note to the documentation on the default behavior of the verify so that one cannot be surprised by the current behaviour (Especially new comers).
What do you think of that?
from yii2-app-advanced.
Let us continue discussion if any on #557
from yii2-app-advanced.
Related Issues (20)
- Tests are not compatible with PHP 8 and Codeception 5 HOT 1
- 安装怎么都不包含vendor目录了
- How to share cookie and session between backend_1 and backend_2
- composer.lock is now in .gitignore
- Docker Installation HOT 1
- fail installation on php 8.2 HOT 3
- When the release with : codeception/verify 2.2 (#521) HOT 1
- Change supported version to 8.1+ HOT 1
- update github folder link
- update backend folder link
- update console folder link
- update docs folder link
- update frontend folder link
- update root folder links
- yii migrate Error HOT 4
- Unknown command: schedule/run HOT 1
- Some checks were not successful when pushing changes on a Yii advanced template HOT 7
- php yii migrate doesnt work HOT 1
- Testing app HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yii2-app-advanced.