Giter Site home page Giter Site logo

Comments (8)

bizley avatar bizley commented on May 27, 2024 2

I would remove the login() step it. It will not affect existing apps and new projects will be safer after the change.

from yii2-app-advanced.

SOHELAHMED7 avatar SOHELAHMED7 commented on May 27, 2024 1

There is no problem in existing way. I would say better way is to not automatically log in the user. User can login only if password is provided (login form). Most of the web apps does not automatically log in the user. It just verifies the email address.

from yii2-app-advanced.

machour avatar machour commented on May 27, 2024 1

I think this really boils down to a personal preference. I'd leave the template as it is and as it have been functioning for years.

from yii2-app-advanced.

mtangoo avatar mtangoo commented on May 27, 2024

But it is a template that someone is supposed to adopt to his own need. One will want auto login and another not wanting it, can remove. Can you explain why is it a problem?

I think adding documentation should be enough as we cannot cater every possible use case

from yii2-app-advanced.

mtangoo avatar mtangoo commented on May 27, 2024

I will remove it and document it for those who want to login automatically. What do you think @yiisoft/core-developers

from yii2-app-advanced.

mtangoo avatar mtangoo commented on May 27, 2024

@bizley @rhertogh

from yii2-app-advanced.

mtangoo avatar mtangoo commented on May 27, 2024

I think this really boils down to a personal preference. I'd leave the template as it is

In this case we should put a note to the documentation on the default behavior of the verify so that one cannot be surprised by the current behaviour (Especially new comers).

What do you think of that?

from yii2-app-advanced.

mtangoo avatar mtangoo commented on May 27, 2024

Let us continue discussion if any on #557

from yii2-app-advanced.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.