Giter Site home page Giter Site logo

Comments (4)

ald3rson avatar ald3rson commented on May 26, 2024

Sorry, I just add this on the bottom yii2-client/authclient/src/client/Live.php and it works.

public function applyAccessTokenToRequest($request, $accessToken)
{
    $request->addHeaders(['Authorization' => 'Bearer '. $accessToken->getToken()]);
}

from yii2-authclient.

michael-schaefer-eu avatar michael-schaefer-eu commented on May 26, 2024

I thought that Microsoft does not support the Live OAuth2 authentication method anymore?

When I open this link from the Live class, I get this error:

Bildschirmfoto vom 2022-11-29 14-03-30

Or is it only about the App Registration ?

from yii2-authclient.

edegaudenzi avatar edegaudenzi commented on May 26, 2024

UPDATE: the PR resolving this issue has been closed and not merged by @bizley with the following comment:

Thank you for your contribution but unfortunately we are not adding any more clients. Please release it as a separate package.

Not sure why of this decision and as a result, we are not adding one of the most used external authentication providers, which would also make the plugin "business grade" (hence more popular), being Microsoft365 the reference for the vast majority of Companies around the globe.
Please @bizley give us a little bit more in-deep details if you can, so at least we can close down this issue as 'non-resolved'.

I will not release as a separate package: way too hassle for such a tiny thing, especially if there is already a solution made on purpose to host it.

@readers: if you need this to authenticate your yii2 project against Microsoft365 to follow the normal yii\authclient\OAuth2 mechanism, you can still do that by taking 3 changes from this commit:

  • Updated asset picture with Microsoft365 Logo: src/assets/authchoice.png
  • The extra CSS: src/assets/authchoice.css
  • The main class: src/clients/Microsoft365.php

Live long and prosper \\//_

from yii2-authclient.

bizley avatar bizley commented on May 26, 2024

I understand the frustration but please try to look at this from the maintainers perspective. This is a design decision made 9 years ago. Since then we don't accept new client implementations what you can verify by looking at the not accepted PRs.

3rd-party-made extensions are more than welcome.

@ald3rson please follow the implementation and instructions provided kindly by @edegaudenzi , thank you.

from yii2-authclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.