Giter Site home page Giter Site logo

Comments (4)

bizley avatar bizley commented on June 2, 2024

Hmm, isn't it a problem with the minimizer you are using?

from yii2-debug.

knoppixmeister avatar knoppixmeister commented on June 2, 2024

I use following code in controller's init method for minimizing output on the fly

`
class SiteController extends \yii\web\Controller {
public function init() {
parent::init();

		ob_start(function($b) {
			$res = preg_replace(['/\>[^\S ]+/s','/[^\S ]+\</s','/(\s)+/s'], ['>', '<', '\\1'], $b);
			$res = str_replace(["\r\n", "\n", "\r"], " ", $res);

			return $res;
		});
		
	}

....
....
`

So, because of all debug assets JS files injected directly in html output (not linked as separated JS files) the code above breaks overall JS work.

Also i already rewritten all js files for correct work in minimized mode in debug assets but it will break after package update thru composer.

Also there are few places where used "/* */" style commnets not "//"

from yii2-debug.

bizley avatar bizley commented on June 2, 2024

It's clearly a problem on your side, you could just improve the preg_replace. I know that this change is super easy and should not impact anything but this is just wrong. Anyway @yiisoft/reviewers ?

from yii2-debug.

samdark avatar samdark commented on June 2, 2024

Minimizer regex is to be fixed.

from yii2-debug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.