Comments (4)
Hmm, isn't it a problem with the minimizer you are using?
from yii2-debug.
I use following code in controller's init method for minimizing output on the fly
`
class SiteController extends \yii\web\Controller {
public function init() {
parent::init();
ob_start(function($b) {
$res = preg_replace(['/\>[^\S ]+/s','/[^\S ]+\</s','/(\s)+/s'], ['>', '<', '\\1'], $b);
$res = str_replace(["\r\n", "\n", "\r"], " ", $res);
return $res;
});
}
....
....
`
So, because of all debug assets JS files injected directly in html output (not linked as separated JS files) the code above breaks overall JS work.
Also i already rewritten all js files for correct work in minimized mode in debug assets but it will break after package update thru composer.
Also there are few places where used "/* */" style commnets not "//"
from yii2-debug.
It's clearly a problem on your side, you could just improve the preg_replace. I know that this change is super easy and should not impact anything but this is just wrong. Anyway @yiisoft/reviewers ?
from yii2-debug.
Minimizer regex is to be fixed.
from yii2-debug.
Related Issues (20)
- Store data in a cache HOT 3
- User switching is not working when using custom User model id HOT 1
- Mailpanel should store message in request data HOT 1
- Feature: Show repeating DB calls from the same function (regardless of the parameters) HOT 8
- User switch not working if User model has JSON/Array column HOT 2
- Don't use table-danger to indicate excessive queries HOT 3
- DB summary view uses $criticalQueryThreshold directly instead of checking via isQueryCountCritical() method HOT 2
- Mail panel broken for Symfonimailer HOT 1
- List of queries in debug panel is empty when Connection::enableProfiling is false
- Display transaction begin/end in debug panel database queries list
- DbPanel::excessiveCallerThreshold should be disabled by default
- Object of class Symfony\Component\Mime\Header\Headers could not be converted to string HOT 2
- update irc link
- update github folder link
- update docs folder links
- Switching user back to admin user is not possible when using access rules
- update src folder links
- update root folder links
- Generating a url with a trailing slash
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yii2-debug.