Giter Site home page Giter Site logo

Comments (15)

ykdojo avatar ykdojo commented on July 27, 2024 1

I was thinking of implementing something on my own and comparing it to yours.

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024 1

Also thanks for your code, @justafrank. I got a lot of inspiration from your code for that video.

from editdojo.

haruntuncay avatar haruntuncay commented on July 27, 2024

Hi @ykdojo . Can I be assigned to this please ?
And, I think, added characters in the edited text should also be highlighted with maybe something like greenish background color.

Original text: I had aweesome breakfast tooday.
Edited text: I had an awesome breakfast today.

So it may give an output like this:

<p>I had <span class="appended">an</span> awe<span class="deleted">e</span>some breakfast to<span class="deleted">o</span>day.

Where the appended words/chars are wrapped in a span with class .appended, and deleted words/chars are wrapped in a span with class .deleted.

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

That sounds perfect! I tried assigning this to you on GitHub, but it didn't work for some reason. Feel free to just start working on it and send a pull request when it's ready :)

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

Found this library, but not sure if it would be a good fit for this: https://github.com/jhchen/fast-diff

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

Maybe it would be better/simpler to just implement this ourselves? That way, it'll be easier to tweak it as we go, too. I just don't like how most of these libraries are really complex to read and edit... Anyway, I'll think about this some more.

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

Started working on this today.

Pretty raw and it might be hard to read, but I have some code here already: https://github.com/ykdojo/text_difference_finder

from editdojo.

franktzheng avatar franktzheng commented on July 27, 2024

Hey @ykdojo did you look at my pull request (#25)?

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

@justafrank hey sorry I thought I'd submitted my comments already. I just sent them again.

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

Here are some examples for testing, in English:

  • Hello I’m looking of the group for learn english.
    -> Hello, I’m looking for a group to learn English with.

  • what book are you reading ? i want to start this one… what do you think about ?
    -> What book are you reading? I want to start this one… What do you think about it?

  • who helps me for improving my English?
    -> Can anyone help me improve my English?

  • I am waiting for snow from this morning until now.
    -> I’ve been waiting for snow since this morning.

  • even I have French nationality. I still make mistake when I write my own sentences .
    -> Even though I’m French, I still make mistakes when I write in French.

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

And some test cases in Japanese:

  • 日本語でも英語でもドラマよく見ている。
    -> 日本語でも英語でもドラマをよく見ています。
  • きのうのばんごはんはとてもおいしかたです。
    -> きのうのばんごはんはとてもおいしかったです。
  • わたしのしごとのま、わたいはそうだいなけしきをみました
    -> しごとのあいまにきれいなけしきをみました。
  • 知らない人とお喋りのが怖いです。
    -> 知らない人とお喋りするのが怖いです。
  • Duolingoは本とに凄いアプリです。
    -> Duolingoは本当に凄いアプリです。
  • 今朝はとても寒い!冬ははやく来る。
    -> 今朝はとても寒いですね!冬がもうすぐ来そうです。

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

I'm starting to think, ideally, there should be a custom solution for splitting a sentence into words for each language.

Splitting by spaces work well for English, but it won't work well for Japanese, for example.

I think splitting a Japanese sentence into individual characters works well enough for now though.

from editdojo.

franktzheng avatar franktzheng commented on July 27, 2024

I changed a few lines of code, which split the strings by character. Having the option to split by words or character should be enough to cover most languages, I think.
textdif
Should I submit another pull request?

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

Sure, that sounds perfect.

I made my own version here, so I might pick yours or mine, or try merge them later on.

So one of the reasons I wanted to make my own version is because I wanted to learn how it works myself, and another reason is just because I wanted to make a video about it.

Anyway, I think it's good to have multiple solutions available to choose from :)

from editdojo.

ykdojo avatar ykdojo commented on July 27, 2024

Solved this in my last video. I'll close this issue for now. https://youtu.be/4SP_AY7GGxw

from editdojo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.