Giter Site home page Giter Site logo

Comments (4)

mudream4869 avatar mudream4869 commented on June 15, 2024

This code actually does not remove ALL networks.

_, all, _ := net.ParseCIDR("0.0.0.0/0")
ll, _ := trie.CoveredNetworks(*all)
for i := 0; i < len(ll); i++ {
	trie.Remove(ll[i].Network())
}

For example, if we first insert 192.168.1.0/24 and 192.168.1.1/32, then try to remove "all networks" by code snippet above, the trie will still leave 192.168.1.1/32.
The reason is that the CoveredNetworks function only return one network 192.168.1.0/24 in the case above. The Remove operation is implemented as just removing the node but if any child exists then the child will leave.
Test on playground ➡️ https://play.golang.org/p/7NRBI_zBYb5

from cidranger.

yl2chen avatar yl2chen commented on June 15, 2024

@danmia Thanks for posting the tests to show the memory leak, and sorry I only got to investigating now, I have provided the fix and incorporated your test in the unit test suite.

from cidranger.

yl2chen avatar yl2chen commented on June 15, 2024

I will leave the PR unmerged for some time, to give you a chance to independently verify that the memory leak upon removal is addressed, thanks!

from cidranger.

danmia avatar danmia commented on June 15, 2024

Thanks for looking into it! It looks good in my local tests. This is super useful. Thanks again!

from cidranger.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.