Comments (10)
@corneliusroemer Thank you for your suggestion and even for the swift PR 👓
However, instead of changing the current defaults for themes including colors, I'm considering designing a config file that allows users to set their terminal themes on their side.
from jnv.
@daviddenton cc @corneliusroemer
Thank you for using it ✌️ and I understand your point about wanting to temporarily change the color scheme for better visibility.
In that case, let's proceed with merging #4.
However, I have one comment. I would like to differentiate the colors for each UI component, so I want to separate the colors for readline prompt (=prefix) and JSON keys.
prefix_style: StyleBuilder::new().fgc(Color::Cyan).build(),
key_style: StyleBuilder::new().fgc(Color::Cyan).build(),
As a note, since most of the colors other than the Darkxxxx
presets are already in use, it might be a good idea to specify using Color::Rgb { r: (), g: (), b: () }
. If you have any suggestions for good colors, please let me know.
from jnv.
Splitting the colours for maximum tweaking is probably great from a colourblind perspective so I do think that would be a good option. No preferences on colour really as long as it's lighter than the dark blue 😉
from jnv.
Firstly - JNV is great - so useful already - but I (and my pair) also struggled with the colour-scheme.
As a maintainer myself - I understand that you'll want time to do a proper job on the config file (which also sounds like a great idea btw). Would it be worth merging/release this in the meantime, which would be the best of both worlds? 😄
from jnv.
100% agree, I very nearly gave up on using jnv
purely because of this issue.
from jnv.
@corneliusroemer Thanks for your contributing 👍 I just released v0.1.2. Please check.
from jnv.
+1 for the color review, same issue - on a side note, excellent tool @ynqa !!! 💯
from jnv.
A workaround is to change the colormap of your terminal's ANSI colors - this is actually a more sustainable change for readability. I'm using hyper and I can change the hex code for Blue (the color that's particularly hard to read) - that way that color becomes more readable for all tools and no longer needs to be avoided outright.
Terminal level customizability of ANSI colors is one of the reasons why using explicit rgb might harm accessibility @daviddenton If you are red-green color blind, the best thing to do is to remap the hex codes for the corresponding ANSI codes.
from jnv.
Yah! This now works, excellent, thanks! @ynqa
from jnv.
yep. So much better! Thanks 🙃
from jnv.
Related Issues (20)
- Feature Request: Support JSON stream HOT 8
- Feature: Configure the highlighted 'current' line to NOT be at the top of the screen
- Add jnv to homebrew-core HOT 2
- Not running by default on AlmaLinux 8
- ENH: Support newline delimited JSON (ndjons/jsonl) HOT 7
- Colours are unreadable when used with a light terminal background. HOT 1
- It's a very cool tool, does it work on bash? or it depends on system(Linux/MacOS)? HOT 4
- blinking when using xterm -cm HOT 4
- jnv cannot trigger auto-completion while use array HOT 1
- feature request: Publish as a docker image HOT 5
- Releasing armv7 and arm64 binaries HOT 1
- Fails to execute jq query when the key starts with `@` symbol HOT 4
- Feature Request: configure keymap/colors
- How about replacement `jq` with `jaq`? HOT 5
- Feature Request: Copy current JSON displayed HOT 2
- ENH: Add `-s` slurp mode, turning json-lines into an array
- What terminal settings should you use?
- Specify default query
- Feature Request: Write the output to stdout
- [FR] Support for query history
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jnv.