Comments (9)
Running spec also skips lookup tests:
Skipping LU vies lookup spec
.Skipping LU vies lookup spec
.Skipping LU vies lookup spec
..Skipping IE vies lookup spec; result = nil
Skipping LU vies lookup spec; result = nil
.Skipping LU vies lookup spec
.Skipping LU vies lookup spec
from valvat.
I don't know whats wrong with the VIES, but specifying the message_tag for savon makes it work again:
c = Savon.client(wsdl: 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl')
c.call(:check_vat, message: { countryCode: 'SE', vatNumber: '556074308985' }, message_tag: :checkVat)
from valvat.
After manipulating the Gemfile.lock I noticed that the source of the problem might be wasabi.
running bundle update
wasabi is set to 3.3.1
.
Setting wasabi to 3.3.0
in the Gemfile.lock, running bundle install
, the specs pass
from valvat.
Sorry for the long delay.
@wildjaX I am not able to reproduce your error.
Valvat::Lookup.new("DE345789003", {:raise_error => true}).validate
just returns 'false' without any exception raised. Are you still able to reproduce it? After some years i am a little bit sceptical regarding the stability of the VIES-api ;)
@anajavi Some specs in valvat run against the live VIES api and will be skipped because the VIES-api is going down for specific EU-nations several times a week. If you know any better solution to this problem let me know.
from valvat.
I was a little bit to quick with the last reply.
After updating to wasabi 3.3.1 the specs broke. I'll look into this and let you know if there is any progress. Temporary fix would be to manualy specify a dependency on wasabi 3.3.0
from valvat.
@yolk Thanks for the reply.
Maybe it would make more sense fixing it in savon, since it actually requires wasabi?
I think we could close the issue, since the Problem doesn't come from valvat itself.
from valvat.
@wildjaX Yes, this is an salvon issue and should be fixed there.
But to watch the progress, I think I gona keep the issue open. Maybe I'll have to temporarily fix it in valvat, we'll see.
from valvat.
I fixed the issue in version 0.6.7. Feedback would be awsome!
from valvat.
Thank you very much! Works like a charm with wasabi 3.3.1.
from valvat.
Related Issues (20)
- Periodic Savon::UnknownOperationError when validating VAT HOT 8
- Warning on Ruby 3.x: `character class has duplicated range` HOT 1
- `Savon::HTTPError` not handled gracefully HOT 2
- Support for Apple Distribution International in Italy HOT 4
- The given SOAPAction checkVat does not match an operation HOT 1
- Support for Northern Ireland (XI) HOT 1
- No response returned as of 2022 HOT 13
- Missing dependency rexml? HOT 1
- Add caching HOT 4
- Equality for Valvat objects HOT 1
- Valvat::Checksum.validate returns an exception for some invalid VAT numbers HOT 5
- Getting Nil in all validate cases HOT 3
- Incorrect spelling
- undefined method `exists?' for #<Valvat XXX> HOT 2
- Release a new gem version? HOT 1
- Cannot validate HOT 5
- How to test errors? HOT 1
- Portuguese translation failing due to missing space on locale yml file HOT 1
- Incompatibility with Ruby 3.0.0 HOT 11
- Implement VAT validation for GB VAT numbers HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valvat.