Support xcconfig

[yonaskolb]

Support xcconfig

[yonaskolb]

Hi @toshi0383, thanks for the suggestions!

Yeah, you're right there's no way to specify a project's xcconfig file. Setting configFiles on a target should be working though. Is it not?

In terms of adding them to the project, I'd like to keep defining configurations and applying xcconfig files in seperate dictionaries. While it's not hugely documented at the moment the include feature is highly used by myself and others, and seperating them makes the feature work better. Also it's nice to keep consistency between a project and a target in how things are defined.

About the renaming, I agree maybe configs to configurations would be better. I'd like to keep configFiles though, but would be open to configurationFiles. In either case, both the project and target properties should match.
Obviously both of these are breaking changes, so would need a major version bump, or still read the old values.

Feel free to get a PR up and going! 👍

[toshi0383]

Yeah, you're right there's no way to specify a project's xcconfig file. Setting configFiles on a target should be working though. Is it not?

Yeah maybe my spec is wrong. Would you mind sharing a working example spec for me?

In terms of adding them to the project, I'd like to keep defining configurations and applying xcconfig files in seperate dictionaries.

Could you share outline spec? I don't see the whole picture yet, since I haven't used include feature.
It's XcodeGen specific feature, right?

I agree maybe configs to configurations would be better.

Alright. I will fix this maybe in different PR.

I'd like to keep configFiles though, but would be open to configurationFiles. In either case, both the project and target properties should match.

Great! I will take configurationFiles, because it's better suited to the Cocoa API naming conventions.

Obviously both of these are breaking changes, so would need a major version bump, or still read the old values.

Sure, I am going to at first deprecate it and add warning message when people use the old values.
[warning] configFile is deprecated. Use configurationFiles instead.

[toshi0383]

Could you share outline spec? I don't see the whole picture yet, since I haven't used include feature.

So this is what I came up with. What do you think?

name: MyProject
configurations:
  Debug: debug
  OTA: release
  Release: release
configurationFiles:
  Debug: configs/MyApp-Debug.xcconfig
  OTA: configs/MyApp-OTA.xcconfig
  Release: configs/MyApp-Release.xcconfig
targets:
  MyApp:
    type: application
    platform: iOS
    sources: Sources/MyApp
    settings:
      PRODUCT_BUNDLE_IDENTIFIER: jp.toshi0383.hello
    configurationFiles:
      Debug: configs/MyApp-Debug.xcconfig
      OTA: configs/MyApp-OTA.xcconfig
      Release: configs/MyApp-Release.xcconfig

[toshi0383]

🚀