Giter Site home page Giter Site logo

Comments (6)

magixbox avatar magixbox commented on July 30, 2024

Yes, it makes sense to have such feature. And do away with the hardcoded 7 digits handling - we do need those SMS.

from envayasms.

youngj avatar youngj commented on July 30, 2024

Thanks for the input! Could you describe the situation where you need to handle SMS from phone numbers with less than 7 digits? Are these regular mobile phones, or shortcodes?

from envayasms.

magixbox avatar magixbox commented on July 30, 2024

I am not sure about other countries, but in Malaysia, it is quite common to receive SMS in shortcodes (4 to 6 digits), sending from international gateway or Celco itself.
It is also possible to receive none-numeric sender identity occasionally - which is rare these days as Celco has started to filter them off.

These SMS usually contain essential information such as credit balance notification and usage related alerts.

from envayasms.

youngj avatar youngj commented on July 30, 2024

Thanks for the information.

The purpose of the 7 digit minimum is to avoid forwarding marketing solicitations (typically from shortcodes) and notifications from the mobile network (typically from non-numeric senders). In particular, if EnvayaSMS is configured not to store incoming SMS in the inbox, forwarding notifications from the mobile network can make the phone difficult to manage.

I think 7 digits is a reasonable default for deployments that only want to forward SMS from "real" mobile users, but I could understand why someone might want to forward all SMS.

Instead of changing the minimum sender length from 7 to 0 for all EnvayaSMS users, I think there should be a new checkbox setting that allows the user to choose.

from envayasms.

magixbox avatar magixbox commented on July 30, 2024

Agreed.

Unfortunately crafting out such option (having checkbox setting at Envaya Android app) is really beyond my "programming" capabilities. I'll have to leave that for you good people at Envaya for now.

from envayasms.

youngj avatar youngj commented on July 30, 2024

Implemented in 22f8c26 (version 2.0.3)

from envayasms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.