A few feature requests

[yuanchuan]

A few feature requests

[yuanchuan]

Hi @POPCORNS1068,

The last two features actually are more likely based on the first one. But I'm concerned about the efficiency of scanning when the directory is too deep.

It did that in earlier versions of node-watch (<=0.3.x) and it's hard to go back now.

Anyway, PRs are welcome and I'd love to add the create event if it is implemented other than scanning.

Maybe make them optional like the recursive option?

Oops that was unintentional

[yuanchuan]

That may be huge work :D
Could you share your current workarounds?

For the initial scan, I used this snippet here (modified to create a tree instead of a list): https://stackoverflow.com/questions/5827612/node-js-fs-readdir-recursive-directory-search.

I made it add the found dirs/files to a tree and keep it updated with the change events (add updated dir/file into tree if it's not already in it, remove if it's removed)

As for the last one, since I already have a tree of files, when a remove event occurs for a directory, I remove (and report) that dir and it's contents in that tree, recursively.

I'm not that into js so that's I could come up with.

[yuanchuan]

I'm going to leave it open to see if anyone upvote for this.

[kgrajek]

"Initial Scan" would be great feature!

[octachrome]

I am also switching from chokidar (because recursively watching on Windows locks all subdirectories so that they cannot be renamed or deleted), and I have similar feature requests:

• I implemented initial scan using readdirp, with a counter to ensure the scan stops early when the directory tree is too deep
• I am thinking of implementing individual file events on rm -rf by maintaining a list of all files in the directory
• I also need to workaround an issue on Linux where copying a deep directory structure into a watched directory does not fire events for new files, because the recursive watch is added too slowly. I will probably resolve this by using readdirp to find the directory contents whenever a new directory is created.

[fabiospampinato]

I would very much like to see the points in the first post addressed, especially the third one would be a deal breaker for me, if a file is deleted and I don't get an event about that file I'd consider it a bug even.

[fabiospampinato]

I wanted to submit a PR with those missing features, but I ended up rewriting the whole thing, now it should do pretty much everything except for supporting symlinks, I'll leave a link to it here in case somebody here is interested: https://www.npmjs.com/package/watcher