Comments (2)
Since the registration object in the example is never marshalled into a Registration the id should still be there from the database (admittedly this is fragile).
Have you tried this and observed it not working?
from php-u2flib-server.
Yeah, you are right (I discovered it just after I posted the issue), however this is really a bad way of doing that :).
I my own application I made for now a extended version of Registration, which actually includes the ID in my code, and use that to pass around.
I would also suggest to have in the main API a check for instanceof Register, instead of using is_object to see if it is a object. You expect a Register object, and not a random object (Like currently a stdClass in case of the PDO example).
from php-u2flib-server.
Related Issues (20)
- Vagrantfile HOT 1
- Split U2F.php into files per Class HOT 1
- PSR-4 Autoloading HOT 2
- Problems with Challenge HOT 2
- Correct handling of errorCode 0 HOT 1
- can you make more Releases
- PHP 7 Support HOT 1
- Unit Tests are Failing HOT 1
- Library fails with mbstring.func_overload HOT 2
- Firefox support HOT 12
- Errorcode 2 in registrater a new user HOT 1
- PDO example not working HOT 2
- Making openssl_random_pseudo_bytes usage more reliable
- u2f-local.php not working HOT 2
- Example not working in Firefox 60.1.0 HOT 2
- missing id in castObjectToRegistration function HOT 3
- Any support for GO? HOT 1
- Sample usage? HOT 1
- PHP Preloading incompatibility HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-u2flib-server.