Expose `account-domain` setting with suitable warnings

[yunohost-apps]

Expose `account-domain` setting with suitable warnings

[ndarilek]

Understood. Thanks for taking the time to explain.

[OniriCorpe]

Hi @ndarilek!

This should be available with the upcoming packaging of the v0.7.1 (see #65), but only for fresh installs (since changing domain name parameters breaks GTS) ^w^

[OniriCorpe]

the 'account_domain' stuff was breaking the CI tests 😣
after a lot of work trying to get around this, I cannot continue with the "account-domain" implementation

what it would take to make it work:

• that the CI test offers more than 2 test domains (domain.tld and sub.domain.tld)
• that the ynh_add_nginx_config function can take a domain name and a configuration template as parameters

I'm sorry @ndarilek but it won't be for this time :/

[ndarilek]

Awesome, thanks for trying. Would it be possible to just support the config parameter and require the user to configure it themselves? For example, I have my own well-known.conf that I add to my nginx domain. It forwards Matrix's .well-known to my non-YNH-Hosted Synapse. It also redirects AP endpoints to my Friendica account so my email address 301s to wherever my fediverse account happens to be ATM. I'm thinking the value would just get added into the template, and the user would have to create their own config file with samples from the readme and suitable warnings about not changing it later. Thoughts? Thanks again.

[OniriCorpe]

it's difficult because you need to do this configuration before the first launch of GTS

and that the configuration file is rewritten at each update from the template and the arguments loaded in the update script

so a parameter added manually would be overwritten at each update

and if I put an argument in the installation and update files, it is not accessible to the user without going through the input fields at installation
so I am obligated to make an user input at installation, so I have to take it into account during automatized tests

so, for now, I'm stuck and I can't do it without a big gross hack that would then have to be maintained over time and can break anything at any time

and since I'm forced to take the CI into account, I'm also stuck because it limits me to 2 domain names and no matter how I do it, it ends up in a nginx configuration conflict (because of the possibility of installing multiple instances of GTS)

[OniriCorpe]

that the ynh_add_nginx_config function can take a domain name and a configuration template as parameters

I have started (and maybe finished) to do this
I'll have to check my work when I have some energy and propose its integration in the yunohost's core

[ndarilek]

This feature is something I'd really like to have.

Is there anything I can do to help, up to and including finishing the work you've started in core? I'm not new to development, just to working on YNH, so if it's far enough along but just needs a push over the finish line then I'd be willing to try taking it over and reaching out to other core developers for help.

There are a lot of Fediverse projects that either have or want this feature, so it'd be nice if it could be slotted into YNH.

Thanks.