Cannot backup using yunohost 4.3.0+202109211353

[fflorent]

Cannot backup using yunohost 4.3.0+202109211353

[fflorent]

Note that if I change any call of ynh_print_info to ynh_script_progression in scripts/backup, I don't have any error message anymore.

@ericgaspar If you think that's the right way to solve the issue, I would be glad to propose a PR.

[ericgaspar]

This is odd. I don't see anything wrong with the backup script... oO Let's see the CI output.

[fflorent]

I see the same error in the CI (this error was not the one I expected at the first time, it comes from my PR #16 ):

287  INFO Now upgrading meilisearch...
1785 INFO [....................] > Loading installation settings...
2823 INFO [+...................] > Ensuring downward compatibility...
4574 INFO [#+..................] > Finding an available port..
5116 INFO [##++++..............] > Backing up Meilisearch before upgrading (may take a while)...
7737 WARNING 2088 Invalid argument: --
9246 WARNING 3600 Could not back up meilisearch
9269 WARNING 3623 Nothing to save
9373 WARNING Backup failed, the upgrade process was aborted.
10376 ERROR Could not upgrade meilisearch: An error occurred inside the app upgrade script
10385 INFO The operation 'Upgrade the 'meilisearch' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20211008-072848-app_upgrade-meilisearch' to get help
10407 WARNING Here's an extract of the logs before the crash. It might help debugging the error:
10408 INFO DEBUG - 1933 + [[ -z '' ]]
10409 INFO DEBUG - 1933 + dest_path=etc/systemd/system/meilisearch.service
10409 INFO DEBUG - 1935 + [[ -e etc/systemd/system/meilisearch.service ]]
10409 INFO DEBUG - 1937 + local rel_dir=/apps/meilisearch/backup
10410 INFO DEBUG - 1938 + rel_dir=/apps/meilisearch/backup/
10410 INFO DEBUG - 1940 + dest_path=/apps/meilisearch/backup/etc/systemd/system/meilisearch.service
10410 INFO DEBUG - 1941 + dest_path=apps/meilisearch/backup/etc/systemd/system/meilisearch.service
10410 INFO DEBUG - 1943 ++ sed --regexp-extended 's/"/\"\"/g'
10410 INFO DEBUG - 1945 ++ echo /etc/systemd/system/meilisearch.service
10410 INFO DEBUG - 1949 + local src=/etc/systemd/system/meilisearch.service
10410 INFO DEBUG - 1953 ++ echo apps/meilisearch/backup/etc/systemd/system/meilisearch.service
10410 INFO DEBUG - 1954 ++ sed --regexp-extended 's/"/\"\"/g'
10410 INFO DEBUG - 1959 + local dest=apps/meilisearch/backup/etc/systemd/system/meilisearch.service
10410 INFO DEBUG - 1959 + echo '"/etc/systemd/system/meilisearch.service","apps/meilisearch/backup/etc/systemd/system/meilisearch.service"'
10411 INFO DEBUG - 1962 ++ dirname /home/yunohost.backup/tmp/meilisearch-pre-upgrade1/apps/meilisearch/backup/etc/systemd/system/meilisearch.service
10411 INFO DEBUG - 1966 + mkdir --parents /home/yunohost.backup/tmp/meilisearch-pre-upgrade1/apps/meilisearch/backup/etc/systemd/system
10411 INFO DEBUG - 1973 + ynh_print_info '--message=Backup script completed for Meilisearch. (YunoHost will then actually copy those files to the archive).' --time --last
10411 INFO DEBUG - 2072 + ret_code=1
10411 INFO DEBUG - 2073 + echo 'Invalid argument: --'
10412 INFO DEBUG - 2073 + exit 1
10412 INFO DEBUG - 2073 + ynh_exit_properly
11286 ERROR The operation 'Upgrade the 'meilisearch' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20211008-072848-app_upgrade-meilisearch' to get help

--- FAIL ---

[ericgaspar]

There was a bug in the backup script for version 0.15 (f6d8756)
ynh_print_info --message="Backup script completed for Meilisearch. (YunoHost will then actually copy those files to the archive)." --time --last (ynh_print_info can't take --time --last) It has been fixed with adb7881

[fflorent]

Argh, that might explain the issue here! Thanks, I am testing that!

[fflorent]

Indeed, that fixes the issue. Thanks!