Comments (8)
I will close this issue and open a new one to specifically address "release automation".
I share your point. A new issue about release automation can be created and we can close this one.
Usually, I trigger a release by pushing a tag then the whole release process is automated (no manual step or confirmation). So it's not a continuous delivery/release because we still have to tell when we want to release (that's my confirmation step).
Did you have something else in mind?
Creating and pushing a tag is a manual action so it looks like a good solution to me. 👍
from kroki.
I think we can give it a try so that we move all the tools to the same place. And if it's faster and more stable at the moment it's also a good point.
If we have to bring it back to Travis, you will just have to enable the repository in Travis' again and put back the .travis.yml
file so it's not a big deal.
@Mogztter would you like me to try it and make a pull request between today and wednesday for that or do you want to take care of it?
from kroki.
If we have to bring it back to Travis, you will just have to enable the repository in Travis' again and put back the .travis.yml file so it's not a big deal.
You're right.
would you like me to try it and make a pull request between today and wednesday for that or do you want to take care of it?
Please feel free to work on it, that would be greatly appreciated 🙏
from kroki.
I got something working but the tests take 21 minutes to be run completely against 15 minutes on Travis CI.
I haven't checked if some optimizations could be done so I'm going to investigate if I can shorten the build time.
The GitHub Actions results in my fork are accessible here: https://github.com/groovytron/kroki/runs/606295638?check_suite_focus=true
Thanks in advance for your feedback.
from kroki.
The GitHub Actions results in my fork are accessible here: https://github.com/groovytron/kroki/runs/606295638?check_suite_focus=true
Thanks in advance for your feedback.
Many thanks that's really good! 👏
I got something working but the tests take 21 minutes to be run completely against 15 minutes on Travis CI.
15 minutes and 43 seconds 😉
But indeed it's slower! However, I believe that the start is faster on GitHub (ie. before the job is actually running).
The "Install python 3.8.1" step is taking a lot of time... I think we should move the Python part in a parallel job:
- Install Python
- Install requirements (locally)
- Run unit tests
We don't need the above steps to build the Docker image, so it should be safe to run in a separated job. What do you think?
from kroki.
As for the automatic release, it might be a bit more complicated than the testing. I'm not fond of releasing without a human confirmation that triggers the release. And unfortunately GitHub Actions does not offer manual triggerable actions at the moment.
But maybe you have another opinion about that @Mogztter ?
from kroki.
Sorry about that, this issue is probably too broad, I think we should treat the release automation in another issue.
I will close this issue and open a new one to specifically address "release automation".
As for the automatic release, it might be a bit more complicated than the testing. I'm not fond of releasing without a human confirmation that triggers the release. And unfortunately GitHub Actions does not offer manual triggerable actions at the moment.
Usually, I trigger a release by pushing a tag then the whole release process is automated (no manual step or confirmation). So it's not a continuous delivery/release because we still have to tell when we want to release (that's my confirmation step).
Did you have something else in mind?
from kroki.
Closing, thanks again for your work @groovytron
from kroki.
Related Issues (20)
- Generating a Mermaid SVG differs from a generated PNG.
- Excalidraw not working on Kubernetes? HOT 3
- excalidraw companion server not using local assets HOT 5
- Export metrics as Prometheus/OpenMetrics format at /metrics
- Update Kubernetes documentation to remove blockdiag and wireviz services
- Convert duration that increases over time (public instance)
- Documentation at docs.kroki.io is out of date HOT 5
- TikZ not working on arm64 HOT 4
- port not available HOT 3
- unable to produce plantuml C4 diagram HOT 1
- Excalidraw: add option to embed fonts into svg
- Way to turn off certificate validation for plantuml !includeurl's HOT 1
- Add support for TextUSM
- Structurizr: "filtered" view is not supported HOT 2
- Structurizr: How to generate keys / legends? HOT 4
- Cannot render diagram image with !include <C4/C4_Sequence> HOT 1
- Update Java version to 17 or 21 HOT 2
- Mermaid Converting Not Working HOT 1
- #Try - Mermaid Error 400 HOT 2
- Support for choosing the layout engine for D2 in GitLab code blocks HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kroki.