Giter Site home page Giter Site logo

Comments (8)

groovytron avatar groovytron commented on May 23, 2024 1

I will close this issue and open a new one to specifically address "release automation".

I share your point. A new issue about release automation can be created and we can close this one.

Usually, I trigger a release by pushing a tag then the whole release process is automated (no manual step or confirmation). So it's not a continuous delivery/release because we still have to tell when we want to release (that's my confirmation step).
Did you have something else in mind?

Creating and pushing a tag is a manual action so it looks like a good solution to me. 👍

from kroki.

groovytron avatar groovytron commented on May 23, 2024

I think we can give it a try so that we move all the tools to the same place. And if it's faster and more stable at the moment it's also a good point.

If we have to bring it back to Travis, you will just have to enable the repository in Travis' again and put back the .travis.yml file so it's not a big deal.

@Mogztter would you like me to try it and make a pull request between today and wednesday for that or do you want to take care of it?

from kroki.

ggrossetie avatar ggrossetie commented on May 23, 2024

If we have to bring it back to Travis, you will just have to enable the repository in Travis' again and put back the .travis.yml file so it's not a big deal.

You're right.

would you like me to try it and make a pull request between today and wednesday for that or do you want to take care of it?

Please feel free to work on it, that would be greatly appreciated 🙏

from kroki.

groovytron avatar groovytron commented on May 23, 2024

I got something working but the tests take 21 minutes to be run completely against 15 minutes on Travis CI.

I haven't checked if some optimizations could be done so I'm going to investigate if I can shorten the build time.

The GitHub Actions results in my fork are accessible here: https://github.com/groovytron/kroki/runs/606295638?check_suite_focus=true

Thanks in advance for your feedback.

from kroki.

ggrossetie avatar ggrossetie commented on May 23, 2024

The GitHub Actions results in my fork are accessible here: https://github.com/groovytron/kroki/runs/606295638?check_suite_focus=true
Thanks in advance for your feedback.

Many thanks that's really good! 👏

I got something working but the tests take 21 minutes to be run completely against 15 minutes on Travis CI.

15 minutes and 43 seconds 😉
But indeed it's slower! However, I believe that the start is faster on GitHub (ie. before the job is actually running).
The "Install python 3.8.1" step is taking a lot of time... I think we should move the Python part in a parallel job:

  1. Install Python
  2. Install requirements (locally)
  3. Run unit tests

We don't need the above steps to build the Docker image, so it should be safe to run in a separated job. What do you think?

from kroki.

groovytron avatar groovytron commented on May 23, 2024

As for the automatic release, it might be a bit more complicated than the testing. I'm not fond of releasing without a human confirmation that triggers the release. And unfortunately GitHub Actions does not offer manual triggerable actions at the moment.

But maybe you have another opinion about that @Mogztter ?

from kroki.

ggrossetie avatar ggrossetie commented on May 23, 2024

Sorry about that, this issue is probably too broad, I think we should treat the release automation in another issue.
I will close this issue and open a new one to specifically address "release automation".

As for the automatic release, it might be a bit more complicated than the testing. I'm not fond of releasing without a human confirmation that triggers the release. And unfortunately GitHub Actions does not offer manual triggerable actions at the moment.

Usually, I trigger a release by pushing a tag then the whole release process is automated (no manual step or confirmation). So it's not a continuous delivery/release because we still have to tell when we want to release (that's my confirmation step).
Did you have something else in mind?

from kroki.

ggrossetie avatar ggrossetie commented on May 23, 2024

Closing, thanks again for your work @groovytron

from kroki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.