Force stroke='none' if 'stroke-width' === 0

[sz5000]

Force stroke='none' if 'stroke-width' === 0

[yGuy]

I guess this is a short-coming in Chrome? Anyhow, if the SVG spec says that there should not be a stroke, even if one is specified with a zero width, then we should not write it to the PDF and then the proposed fix sounds like a simple solution.

Can someone confirm that there should never be a stroke visible with a stroke width of 0 in SVG? Maybe the SVG implementation is wrong, already?

[HackbrettXXX]

The SVG 2.0 spec states:

This property specifies the width of the stroke on the current object. A zero value causes no stroke to be painted.

https://svgwg.org/svg2-draft/painting.html#StrokeWidth

The PDF 1.7 spec states:

A line width of 0 shall denote the thinnest line that can be rendered at device resolution [...]

So, yes we shouldn't draw zero-width strokes. The proposal looks good to me.

[HackbrettXXX]

Actually, I think we should rather change

svg2pdf.js/src/utils/text.ts

Lines 10 to 20 in 07b8ca1

	export function getTextRenderingMode(attributeState: AttributeState): TextRenderingMode {
	let renderingMode: TextRenderingMode = 'invisible'
	if (attributeState.fill && attributeState.stroke) {
	renderingMode = 'fillThenStroke'
	} else if (attributeState.fill) {
	renderingMode = 'fill'
	} else if (attributeState.stroke) {
	renderingMode = 'stroke'
	}
	return renderingMode
	}

to make it consistent with

svg2pdf.js/src/nodes/geometrynode.ts

Lines 48 to 79 in 07b8ca1

	protected async fillOrStroke(context: Context): Promise<void> {
	if (context.withinClipPath) {
	return
	}
	const fill = context.attributeState.fill
	const stroke = context.attributeState.stroke && context.attributeState.strokeWidth !== 0
	const fillData = fill ? await fill.getFillData(this, context) : undefined
	const isNodeFillRuleEvenOdd =
	getAttribute(this.element, context.styleSheets, 'fill-rule') === 'evenodd'
	// This is a workaround for symbols that are used multiple times with different
	// fill/stroke attributes. All paths within symbols are both filled and stroked
	// and we set the fill/stroke to transparent if the use element has
	// fill/stroke="none".
	if ((fill && stroke) || context.withinUse) {
	if (isNodeFillRuleEvenOdd) {
	context.pdf.fillStrokeEvenOdd(fillData)
	} else {
	context.pdf.fillStroke(fillData)
	}
	} else if (fill) {
	if (isNodeFillRuleEvenOdd) {
	context.pdf.fillEvenOdd(fillData)
	} else {
	context.pdf.fill(fillData)
	}
	} else if (stroke) {
	context.pdf.stroke()
	} else {
	context.pdf.discardPath()
	}
	}