Giter Site home page Giter Site logo

Comments (8)

suborb avatar suborb commented on June 26, 2024 1

Yes, that's right, it was easiest to take the attribute value from there.

It should affect all graphics functions yes.

from z88dk.

zx70 avatar zx70 commented on June 26, 2024

I managed to refresh w_line_r to use a single index register, apparently it is the only function using IY (-ixiy eventually does the swap).
I'm saving the value in the bss_graphics section, I think it is correct ?

This probably fixes also new the ZX81 library in 384 rows mode.

from z88dk.

suborb avatar suborb commented on June 26, 2024

Yeah bss_graphics is the right section since it'll be shunted up high as necessary for some targets.

I thought +kc was using the compiled C implementation of the drawing primitives to avoid the index register issues.

from z88dk.

zx70 avatar zx70 commented on June 26, 2024

I thought +kc was using the compiled C implementation of the drawing primitives to avoid the index register issues.

It was doing it in most of the cases, but the stencil part calls w_line_* directly and skips the portable primitives.

For what I could see we had only one file in the 'wide' folder dealing with IY, I thought it was worth to changing it.

from z88dk.

suborb avatar suborb commented on June 26, 2024

It was doing it in most of the cases, but the stencil part calls w_line_* directly and skips the portable primitives.

Ah.....I missed that path.

from z88dk.

zx70 avatar zx70 commented on June 26, 2024

The new wide-rez optimized code fits perfectly on the Microbee :)
I know I'm ignoring the color attributes topic but they'd be too many changes at once for me.

I could restore the original library on the KC85, I think the only IY dependent routines were the line and perhaps the circle drawing ones.

from z88dk.

zx70 avatar zx70 commented on June 26, 2024

The new clga() etc optimized code runs very well on the Microbee.

w_stencil_render can be probably replaced with the new one, it contains unfinished opts:

call w_pixeladdress ; bitpos0 = pixeladdress(x,y)

(w_pixeladdress is what the memory banking mess just above is trying to avoid).

EDIT: the new w_stencil_render is not enough generic to work in this configuration, this thing must stay. It performs well by the way.

from z88dk.

zx70 avatar zx70 commented on June 26, 2024

@suborb , I have a question regarding the colour attributes. If Inunderstood correctly they are inherited by the graphics from the same value of foreground+background used in the console text, right?
supposing it affect plot() it should be applied to all the graphics functions, like putsprite() is it correct?

from z88dk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.