Giter Site home page Giter Site logo

Comments (4)

zaccharieramzi avatar zaccharieramzi commented on June 25, 2024

Hi @YYan-97 ,

Those are some errors I got when using the generators, they happen because of some weird problems with the numpy random generator and a race condition which normally should be fine when not using multiprocessing so I am a bit surprised. Which version of the code are you on?

Also, on Monday afternoon I will dedicate my time to fixing the scripts used in this paper since too many of them are outdated (maybe in a separate repo, I will let you know).

You could try fixing this script yourself but I think it would be a bit too much for you.

from fastmri-reproducible-benchmark.

YYan-97 avatar YYan-97 commented on June 25, 2024

Hi @zaccharieramzi ,

I just realized I was using an older version of the scripts. I just tried the latest version, the errors disappeared and it could run successfully. I guess it has something to do with the callback TQDMCallback. In other scripts like pdnet and unet, I modified the TQDMCallback to TQDMProgressBar directly and ran the scripts successfully, so I did not even realize this problem. In kikinet_sep I was not sure how to modify that so I just left it there.

I realized this is a very minor issue. Thank you for your help!

from fastmri-reproducible-benchmark.

zaccharieramzi avatar zaccharieramzi commented on June 25, 2024

Glad to know, so I guess we can close this for now and I will try to still find the will to put this in order

from fastmri-reproducible-benchmark.

zaccharieramzi avatar zaccharieramzi commented on June 25, 2024

Closing this since we now have reproducible scripts thanks to #113

from fastmri-reproducible-benchmark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.