About fastmri_recon/config.py

[zaccharieramzi]

About fastmri_recon/config.py

[zaccharieramzi]

Hi @fharman ,

You are not wrong, there are 108 test files.
These 2 numbers are indeed not accurate but it's not too sever: they are used only in harmless places in the code (for tqdm logging).
I will fix it in a coming PR.

I see that you are still using an old version of the code. As mentioned here, you could now safely use the current version with the dedicated evaluation script to reproduce the results of the paper.

[fharman]

Hi Zaccharie, I want to ask you about the difference. Because the latest one, I remember you used (Glorot uniform(Xavier Initialization,), Rectified Adam for Optimizer, and not used kernel_initializer='he_normal') .But in the new one, there is a difference I realized. Why is there a big difference? Thank you for your return, Best regards, Zaccharie Ramzi <[email protected]>, 27 Kas 2020 Cum, 00:03 tarihinde şunu yazdı:

…

Hi @fharman <https://github.com/fharman> , You are not wrong, there are 108 test files. These 2 numbers are indeed not accurate but it's not too sever: they are used only in harmless places in the code (for tqdm logging). I will fix it in a coming PR. I see that you are still using an old version of the code. As mentioned here <#115 (comment)>, you could now safely use the current version with the dedicated evaluation script <https://github.com/zaccharieramzi/fastmri-reproducible-benchmark/blob/master/fastmri_recon/evaluate/scripts/paper_eval.py> to reproduce the results of the paper. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO4IQ2WZZXT3LMK3PSMSVI3SR27APANCNFSM4UEDULGQ> .

[zaccharieramzi]

@fharman I am not sure what you mean and I don't think it's related to this question.
Please open a new issue if you have another question.

I closed this with the PR #117 being merged.