Giter Site home page Giter Site logo

Comments (2)

zachdaniel avatar zachdaniel commented on June 8, 2024

Ultimately I'd be fine with standardizing the way you've mentioned, but it would involve a major release and/or it would need to be non-default behavior because I wouldn't want to break others' workflow. If that can be accomplished then I'd accept a PR to that effect, including the preset logic.

As for reorienting the config, I'd expect that if it ever grows it would grow as "more metadata per type", which is why it is the way it is now. I'm mostly thinking of users adding their configured types, and I think it's a better experience to see them in the changelog and then decide to hide them vs the other way around. But ultimately I don't care too much as long as the same result is reached 😄.

from git_ops.

thiagomajesk avatar thiagomajesk commented on June 8, 2024

Hey @zachdaniel! I did not think about how to release this change, to be honest, but let's figure this out together...

Ideally, this would in fact be a major release... However, we can also include a default preset option that uses your current convention. That way it would be a smooth upgrade to the new version. The only real difference is for people heavily customizing their types (which I don't think is the case). For those users, they'll have to rename to extended_types if they want to merge with the standard options instead of overriding completely, I'd argue that this would be a very reasonable and low-impact change for a major release. What do you say?

As for reorienting the config, I'd expect that if it ever grows it would grow as "more metadata per type", which is why it is the way it is now. I'm mostly thinking of users adding their configured types, and I think it's a better experience to see them in the changelog and then decide to hide them vs the other way around. But ultimately I don't care too much as long as the same result is reached 😄.

Understood! It makes sense to keep how it is then, thanks for the explanation.

from git_ops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.