Allow trace = FALSE in buildModels

[zachmayer]

Allow trace = FALSE in buildModels

[zachmayer]

This seems a little tricky, as we want to pass trace=FALSE to some models but not others. I see 2 options:

1. Provide an optional list of arguments for the models, e.g. list(nn=list(trace=FALSE), gbm=list(verbose=FALSE))
2. Make methodList an actual list, e.g. list(glm=NULL, rpart=NULL, nn=list(trace=FALSE), gbm=list(verbose=FALSE))

If we go with #1, we can do it post-CRAN release. If we go with #2, I think it should be pre-release.

[zachmayer]

Here's another option that might work, post CRAN release: a methodList class. If a character vector is passed to buildModels, it coerces it to a methodList. The methodList class would be constructed from objects like this:

list(
"glm",
"rpart",
"nnet"=list(trace=FALSE),
"gbm"=list(verbose=FALSE)
)
And would return an object like this:
list(
"glm"=NULL,
"rpart"=NULL,
"nnet"=list(trace=FALSE),
"gbm"=list(verbose=FALSE)
)

In other words, un-named objects in the input list would be ok so long as they were character vectors, and they would be converted to the "model_function"=model_arguments format. The modelList generator could also use modelLookup() from caret to verify that all models are valid.

I think we can safely push this post 1.0, maybe targeting 1.1 or something.

[jknowles]

Yes. This sounds like a great solution.

[zachmayer]

Ok. We'll put that on the agenda for post-1.0.0

[zachmayer]

Closed by #56