Giter Site home page Giter Site logo

Comments (5)

Zaid-Ajaj avatar Zaid-Ajaj commented on July 19, 2024

Hello @cmeeren, the problem with this is that I didn't want want to use apostrophe or back ticks for any of the properties because it always looks foreign and weird for F# beginners, I find the current way of prop.inputType.xxx OK-ish but already has too many dots prop.xxx.yyy; So I am not sure whether adding another level of nesting would help just to have property have a single word per level.

I am open to suggestions, although with this library, it seems to be subjective per user and it is really hard to come up with a consensus that will kind-of satisfy everyone

from feliz.

cmeeren avatar cmeeren commented on July 19, 2024

Personally I find hierarchies pleasant, but I admit that everyone might not feel the same.

In this specific case, I am thinking that, as a general rule, it's easy to do prop.input for all input-related props, prop.appBar for all appBar-related props (MaterialUI component), etc. It enhances discoverability.

For example, there are variant and color enum props for a lot of the Material-UI components. So when I'm working with a button and not sure exactly what I'm looking for, I'd rather not have to type prop.variant and then sort through tens (if not hundreds) of xVariant, yVariant, buttonVariant, zVariant, but instead just go to prop.button and see all available button props.

Just my two cents. :)

from feliz.

Zaid-Ajaj avatar Zaid-Ajaj commented on July 19, 2024

Since Feliz doesn't itself have element-specific properties, adding this one wouldn't make a lot of sense and the current implementation is good enough for now

from feliz.

cmeeren avatar cmeeren commented on July 19, 2024

Agreed. I'm using this for MUI, where it makes more sense.

from feliz.

cmeeren avatar cmeeren commented on July 19, 2024

Just for the record, I just came across the Elm variant, which is called type_:

https://github.com/elm-lang/html/blob/6dee805cd03bf8937936dd564db1c04c64efc5ab/src/Html/Attributes.elm#L428-L433

from feliz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.