Remove Guid overload of text/innerText(/children)

[zaid-ajaj]

Remove Guid overload of text/innerText(/children)

[cmeeren]

Thanks for the clarifications, I agree with both of you. :)

[alfonsogarciacaro]

Yes, Guid is currently compiled as a string, but this (as other Fable hacks) is an implementation detail that may change in the future. Libraries shouldn't rely on this :)

However, I think before we used to erase the String() call when converting Guid to string, but it seems it's not the case now. We could try to do that again :)

[Zaid-Ajaj]

You are right, I have removed it from prop.text and will probably remove prop.innerText altogether

[cmeeren]

Hm... After more research, I am thinking that perhaps anything that accepts string should also accept Guid. The reason is that a Guid is represented in JS by a string (see Fable compatibility docs). So AFAIK there is actually no conversion; you can simply unbox a Guid as a string and it will always work, no explicit stringifying or parsing involved. (Is that right, @alfonsogarciacaro?)

What do you think?

The same could be said for char too, since that's represented by string.

[MangelMaxime]

It's dangerous to base your library implementation on the internal representation of the types. For example, yes today Guid is represented as string but nothing guarantee that tomorrow it will not be represented by a class.

I think it already happened in the past were decimal were represented using string or number and now we have a class for them and was even considered to use WebAssembly to represents them.

PS: My example can be wrong I didn't check all the facts :) but you get the idea :)

So even if you add Guid or char variant of the helpers, my advice is to avoid "hack" like unbox and use guid.ToString() or string charValue.

[Zaid-Ajaj]

@cmeeren The reasons for not using Guid is not because to save the computation of stringifying it but rather because of the points you mentioned above, it doesn't make much sense and for this example as well, I would rather wait for a good use-case where a user really needs this thing over calling string guid