type attribute is valid for more than just input

[cmeeren]

type attribute is valid for more than just input

[Zaid-Ajaj]

I suggest dropping inputType in favour of withType, and have withType surface all allowed members for any type: withType.submit, withType.date, withType.toolbar.

You could also have a string-accepting member on the prop type: prop.withType "foo" in addition to the enum props. They combine nicely.

@cmeeren I like this idea because it is not good if we keep both inputTypes and withType in the DSL, I will try to implement it soon

[Zaid-Ajaj]

You are right!

I am a bit conflicted on this, I like that inputTypes reflects the possible types for an input but I am not sure I want buttonTypes and menuTypes in the DSL along with a free-text value. I will take a look at what other DSL's do

[Zaid-Ajaj]

Do you have any suggestions on what should be the the property? I have a couple myself but I don't care which one gets in because I think I need to make a choice and if it is really bad (I doubt it) then it can be re-worked later

I am thinking

• prop.withType : string -> IReactAttribute because the with* prefix is common for F# devs
• prop.useType : string -> IReactAttribute kind of OK
• prop.setType : string -> IReactAttribute also kind of OK but I don't like it because it resembles OOP code
• prop.ofType : string -> IReactAttribute meh because there is a react helper in Fable.React for importing 3rd party components called the same

Even with these, withType and setType are my highest candidates because they are closest to what "setting an attribute called type represent". I also use string as input because other that inputTypes, these attributes won't be used a lot (I think)

@cmeeren @MangelMaxime what do you think?

[cmeeren]

Of those, I like withType best. I can't think of better alternatives at the moment. (Well, type', but... 😅)

I also use string as input

I suggest dropping inputType in favour of withType, and have withType surface all allowed members for any type: withType.submit, withType.date, withType.toolbar.

You could also have a string-accepting member on the prop type: prop.withType "foo" in addition to the enum props. They combine nicely.

[MangelMaxime]

withType seems good to be