Comments (9)
Yeah this can closed. Thanks a lot @cmeeren for the suggestions, it was great to see what other options we had before moving forward with the current solution
from feliz.
Hello @cmeeren, thanks a lot for the detailed steps! Though because of this comment in Feliz.MaterialUI#20 it is a show stopper for me, really. Combining enums and functions in one value is soo nice to have and I am using it extensively both in Feliz and now in Feliz.Recharts, makes things so much easier and the code is clearer that other alternatives.
For Feliz.MaterialUI, because it really makes implementation easier, isn't it an idea to introduce a specific baseProps
or htmlProps
for just Feliz.MaterialUI and have the components there inherit that base
type?
from feliz.
Just to be 100% clear: With the "alternative method name" syntax, this would be the usage:
popover.anchorOrigin.topLeft // normal prop like today
popover.anchorOrigin'(10, 20) // method like today but with different name
And the other "property as method" option:
popover.anchorOrigin().topLeft // "prop" like today but as a method to access values
popover.anchorOrigin(10, 20) // method like today
And both of those are deal-breakers for you, am I right?
For Feliz.MaterialUI, because it really makes implementation easier, isn't it an idea to introduce a specific
baseProps
orhtmlProps
for just Feliz.MaterialUI and have the components there inherit thatbase
type?
I'm not sure which implementation you refer to. If you refer to the Feliz.MaterialUI implementation, then no, the implementation is definitely easier the way it is today, without inheritance or duplicated props (particularly duplicated props from Feliz). If you instead refer to the user's implementation (when using Feliz.MaterialUI), then I agree that it would be more pleasant to have a single place to look for props (e.g. only popover
, and not paper
or prop
), though I'm far from convinced it matters enough to justify the added maintenance burden. Personally I have no problem having Mui.popover
with some props from popover
and other props from prop
.
from feliz.
And both of those are deal-breakers for you, am I right?
Yes, not a big fan of the syntax of either really. Again very subjective of me I know, I need to think about it. Though it looks like you almost solved this one here, type resolution is really fascinating in F# 😄
from feliz.
Yep, will experiment with that. If it works (which I think it will), no changes are needed in Feliz.
(Though of course Feliz is free to split the props for separate components, as previously mentioned. It might be nice to have the same Html.someComp [ someComp.someProp ]
syntax for the whole Feliz ecosystem, and it might declutter the prop API by removing unusable props.)
from feliz.
My attempted approach broke down for enum props. So we're back to start, with enum props being the primary hindrance for enabling inheritance.
from feliz.
Another option is not implementing enum props in modules, but as normal props, with underscore-separated names:
type appBar =
static member position_fixed = // ...
static member position_absolute = // ...
Usage:
Mui.appBar [
appBar.foo 1
appBar.bar "baz"
appBar.position_fixed
]
This would enable "static inheritance" as described in the Feliz.MaterialUI issue. However, there's always the danger of name collision with real props, and it's not clear exactly how to document the prop vs. the enum values.
from feliz.
Is there anything left to discuss on this or are we good to close it?
from feliz.
I think it can be closed.
from feliz.
Related Issues (20)
- Q: Documentation on breaking changes in 2.6? [WAS Updating Feliz.UseListener to Feliz 2.6.0] HOT 4
- CSS overflow-anchor property HOT 1
- Error with Feliz 2.7 HOT 2
- Making UseElmish's dispatch function stable
- Feliz.Markdown escapeHtml doesn't seem to work HOT 1
- UseElmish: Failed to resolve import "use-sync-external-store/shim" HOT 3
- `react-markdown` removes the `escapeHtml` property HOT 1
- Clarification and Potential Improvement on PR #480 useEffectOnce behavior HOT 5
- Expanding Feliz.Rechart HOT 3
- Component created with a forwardRef that has generic type parameters loses state HOT 2
- "Directory import use-sync-external-store\shim is not supported" in UseElmish.fs.js HOT 2
- Use with Elmish documentation is lacking integration HOT 2
- Enhance Handling of F# Record Types as Props in ReactComponent Attribute HOT 4
- Explore if Feliz.CompilerPlugin can support POJO made using `[<ParamObject>]`
- prop.pattern produces invalid html HOT 4
- React 19 HOT 4
- Svg attribute `fill-rule` missing
- Update tests and move to github actions [Contributions Welcome]
- Doc changes havent been pushed to site HOT 1
- Feliz.popover auto positioning does not work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feliz.