Support for AWS collector from external cluster

[zalando-incubator]

Support for AWS collector from external cluster

[mikkeloscar]

Yup, that should work, it just uses the AWS SDK for access to SQS, so any valid way of configuring the SDK should work (not tested though).

[jonathangold]

@mikkeloscar thanks for the quick reply. Once I get it working, I'll submit a PR to document the process.

[mikkeloscar]

@mikkeloscar thanks for the quick reply. Once I get it working, I'll submit a PR to document the process.

Awesome! Looking forward to it!

[jonathangold]

@mikkeloscar I've started on my deployment, but I'm getting the following error on the kube-metrics-adapter pod:

time="2019-02-21T21:41:53Z" level=info 
msg="Event(v1.ObjectReference{Kind:\"HorizontalPodAutoscaler\", Namespace:\"omitted\",
Name:\"omitted-hpa\", UID:\"xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx\", APIVersion:\"autoscaling/v2beta1\", 
ResourceVersion:\"XXXXXX\", FieldPath:\"\"}): type: 'Warning' reason: 'CreateNewMetricsCollector' Failed 
to create new metrics collector: no plugin found for {External sqs-queue-length}"

I tried tracing the code-path, but didn't have much luck. Am I missing something obvious? Thanks in advance.

[mikkeloscar]

Are you setting the --aws-external-metrics and --aws-region flags?

kube-metrics-adapter/pkg/server/start.go

Lines 203 to 209 in f4efa28

	awsSessions := make(map[string]*session.Session, len(o.AWSRegions))
	for _, region := range o.AWSRegions {
	awsSessions[region], err = session.NewSession(&aws.Config{Region: aws.String(region)})
	if err != nil {
	return fmt.Errorf("unabled to create aws session for region: %s", region)
	}
	}

kube-metrics-adapter/pkg/server/start.go

Lines 211 to 213 in f4efa28

	if o.AWSExternalMetrics {
	collectorFactory.RegisterExternalCollector([]string{collector.AWSSQSQueueLengthMetric}, collector.NewAWSCollectorPlugin(awsSessions))
	}

[jonathangold]

That was the issue. It's working now! thanks!