Comments (3)
I created and closed #198 , that is basically the same issue. See also the description which showed how to cause an incident with the current behavior, if users think a stack will have isolation for secrets and configmaps.
A drawback of having secrets inside stackset is, that we somehow need to protect from reading secrets from the stackset object.
from stackset-controller.
It should probably be a list of resources in case you have multiple configmaps or secrets.
Alternatively, we could use CDP_BUILD_VERSION version as part of the ConfigMap's name and its reference in the podTemplateSpec. This would create a new ConfigMap for each rollout with immutable content. Old versions could be cleaned up by leveraging ownerReference from the Deployment to the ConfigMap, so that once the Stack is deleted the old ConfigMap gets cleaned up too. (Assuming ownerReferences work for ConfigMaps)
This could work but you have to attach the ownerReference after deployment since the uid is needed in the reference. Would be more magic to do it this way IMO, so I think it would be nicer to have it as part of the stackset definition.
from stackset-controller.
I think it's a great idea to include ConfigMaps which are managed by a Stack. This would help avoid problems when rolling out config map changes where either all Pods load the new config or not at all (if app does not load). Also rolling back configuration would be easy and fast.
This topic came up during our current discussion around decommissioning the legacy Zalando-internal Config Service.
from stackset-controller.
Related Issues (20)
- Unbounded Traffic Switch leads to slow actual switch and high number of pods HOT 1
- Regression: StackSetController chokes on single broken stack HOT 1
- Report stackset/stack information via Prometheus metrics
- Proposal - enable external CRDs: skipper RouteGroup, FabricGateway HOT 6
- jsonschema updates for Kubernetes 1.15/1.16 HOT 1
- enable users to define secrets and configmaps in stackset resource HOT 1
- Detect when controller loses connection to API server
- RouteGroup support HOT 1
- startupProbe Support HOT 2
- Fractional traffic weights don't seem to be set accurately
- metadata from stackset service won't be propagated
- In kube-1.18 we don't write status field anymore HOT 1
- fix transport issue with WATCH
- Some low hanging fruits to improve the coverage:
- Include a tidy check on the CI
- StackSet cannot be created when RouteGroup contains metadata HOT 1
- pre define shunt backend in case routegroups are used HOT 3
- Support 'minReadySeconds' for deployments
- Routegroup Algorithm Support HOT 2
- Cannot overwrite rollingUpdate strategy for Stack's Deployment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stackset-controller.