Giter Site home page Giter Site logo

Comments (6)

jberkus avatar jberkus commented on August 28, 2024

Taken care of with PR #23

from patroni.

CyberDem0n avatar CyberDem0n commented on August 28, 2024

Oh!
We can actually make this feature more smart and even make patroni compatible with postgresql < 9.3

  1. We should query major version in Postgresql.__init__
  2. If version < 9.4 forcefully set use_slots to False
  3. Get rid from pg_xlog_location_diff which exists only from 9.3 and use function utils.lsn_to_bytes (https://github.com/zalando/patroni/blob/master/helpers/utils.py#L45) instead.
  4. Profit

from patroni.

CyberDem0n avatar CyberDem0n commented on August 28, 2024

Hmm, for postgres version < 9.3 formula is a little bit different...
Ok, will move this method into Postgresql and make it version-specific.

from patroni.

CyberDem0n avatar CyberDem0n commented on August 28, 2024

2 wont work for slaves...
We have to know in advance that version < 9.4 in order to create proper recovery.conf but without starting cluster it's not really possible to determine version.

But at least everything else is doable.

#25

from patroni.

jberkus avatar jberkus commented on August 28, 2024

We don't care about supporting < 9.3 Here's why:

  1. Before 9.3, you couldn't remaster over streaming replication, making failover/failback and master change much more complicated.
  2. 9.3 was 2 years ago, and is the supported version in current stable Ubuntu, Debian, and Red Hat.

from patroni.

CyberDem0n avatar CyberDem0n commented on August 28, 2024

Ok, dropped unneeded code.

from patroni.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.