Kubechecks calls gitlab.com instead of privately hosted VCS

[bauerjs1]

Kubechecks calls gitlab.com instead of privately hosted VCS

[djeebus]

Whoops, yup, definitely missed that. This should get us that support though. Thanks for the report!

[bauerjs1]

Great, thanks a lot!

Maybe a clearer description would be something like "The endpoint to listen on for incoming PR/MR event webhooks"? The best explanation imho would be an example configuration 🙂

[djeebus]

Ah, good catch, that hardcoded .com does indicate there's some weird url hackery going on there. Let me try and clean that up real quick. Thanks for the debugging effort!

[bauerjs1]

Looks like this fixes the issue. Kubechecks calls the correct GitLab and is able to retrieve its user info and post comments in the MR 👍🏻

Thanks a lot! :)

[djeebus]

The KUBECHECKS_WEBHOOK_URL_BASE env var is the url that, for example, gitlab should send their webhook requests in order to trigger kubechecks. I'm going to see if I can make that documentation a little less obtuse, it's definitely confusing.

[bauerjs1]

I have tried so set up Kubechecks with the dev image containing your latest changes but I am still not getting it to work completely. Currently, it fails while trying to clone the repo:

4:21PM ERR unable to clone repository, Cloning into '/tmp/kubechecks-mr-clone1436125826'...
fatal: could not read Username for 'https://git.mycompany.com': No such device or address
 error="exit status 128"
4:21PM ERR unable to clone repo locally error="exit status 128"

The could not read Username error could mean that at this point, there might be some credential helper missing or something. However it took me to this line, which also looks like it is still hard-coded to gitlab.com:

cmd = exec.Command("echo", fmt.Sprintf("https://%s:%s@%s.com", user, viper.GetString("vcs-token"), viper.GetString("vcs-type")))

I am not sure though, if that is the cause of the could not read Username error.

EDIT: Or maybe credentials are set correctly for git.mycompany.com but git does not recognize them, because the call goes to gitlab.com 💡

[djeebus]

@bauerjs1 mind taking a look at the pr image built in #55 and see if that works for you?

[bauerjs1]

@djeebus sure, it's just that I am on holidays 🙃 Right now, the image is not available, anymore. I might have one more chance tomorrow, after that I am out for a couple of weeks...

[bauerjs1]

@djeebus I am back and happy to test your changes. From Monday on, I will check back regularly for an available test build.
Cheers

[djeebus]

Should be back up; let me know how it goes?