Ignore Non AR subclasses

[zeisler]

Ignore Non AR subclasses

[markburns]

I've got a local fix for this, so will get a test for it and do a PR
tomorrow and see what you think.
On Thu, 28 Apr 2016 at 01:39, Dustin Zeisler [email protected]
wrote:

I think the bast way to deal with this is to only have these show up when
in debug mode and they should not count as a failure. Since this is not a
blocking issue and only a nice to have I'm going to prioritize less than
the other issues you've have raised.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#44 (comment)

[markburns]

BTW, happy to help contribute to the project if you can give pointers. We have a bit of time to look at improving our test suite, and one option is to look at using active_mocker to speed things up, if we can get it to work

[zeisler]

This was mostly just for debugging and I made the assumption that the model_dir would only contain ActiveRecord models. I could add a flag to ignore such cases.

In my past projects I would put classes as you are mentioning in the lib directory.

[markburns]

That's not the case for us, and not an option really as the project is huge. Model doesn't necessarily mean the Active Record design pattern. It also doesn't necessarily mean ActiveRecord, the Rails gem.
You can have models that are not persisted. Or persistence related classes that are not necessarily domain concepts or 'models'.

I think it would make sense that the project defaults to just skipping over non AR subclasses. Would you agree? It would also solve the problem with concerns modules causing exceptions.

[zeisler]

I think the bast way to deal with this is to only have these show up when in debug mode and they should not count as a failure. Since this is not a blocking issue and only a nice to have I'm going to prioritize less than the other issues you've have raised.