Giter Site home page Giter Site logo

Comments (7)

wookayin avatar wookayin commented on September 24, 2024

Try zeroval instead - a24073f. It is one of breaking changes (I dont know why changed) and should be documented.

from topcoder-greed.

ashashwat avatar ashashwat commented on September 24, 2024

@wookayin Thanks, that fixed it. Keeping the issue open for now.

from topcoder-greed.

vexorian avatar vexorian commented on September 24, 2024

@shivawu why is the new name preferable? ZeroValue is less abbreviated and more consistent with ReturnType; not to mention that it is going to cause this confusion.

from topcoder-greed.

zen0wu avatar zen0wu commented on September 24, 2024

Yes, it should be documented.
I planned to update the wiki but haven't got time today.
zeroval is to keep consistent with the name of string renderer,
there're 3 named renderers now, zeroval, parser, and string.
What do you guys think?

from topcoder-greed.

ashashwat avatar ashashwat commented on September 24, 2024

It is consistent with other names, true.
But the obvious issue is if people simple try to copy their source template it will break the code. From what I think, generally everyone have their own Template.[cpp|py|cs|java] from earlier version.

I am -0 on this.

from topcoder-greed.

wookayin avatar wookayin commented on September 24, 2024

+1 for backward compatibility if possible

from topcoder-greed.

zen0wu avatar zen0wu commented on September 24, 2024

I think a bit of breaking change is OK. 2.0 has a lot of breaking changes, especially the config schema.
I'll put migration guide in the release notes.

from topcoder-greed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.