Unit tests written for specific zendesk instance.

[zendesk]

Unit tests written for specific zendesk instance.

[maximeprades]

@dpawluk @sbkinney thoughts?

[sbkinney]

This is actually a concern we'd discussed previously as well. I'd discussed with @dpawluk and we don't believe there's a compelling reason to keep the tests tied to a specific test account.

If you're interested in rewriting the tests to be generic rather than tied to a specific test instance, we'd welcome the contribution @ocke.

[ggrossman]

Hi,

We've changed the test suite to remove all of the hardcoded ID references.

The test suite should now run cleanly on any Zendesk instance. We also have changed the code to support passing in Zendesk credentials via environment variables when invoking phpunit.

Ideally, we would have unit tests and not just live tests, but we don't have the resources to rewrite the whole test suite at this time.

[ocke]

I saw that. @shanitang did a great job 👍