TypeError: Cannot read property '1' of null in bezierPoint's unit test

[zenozeng]

TypeError: Cannot read property '1' of null in bezierPoint's unit test

[zenozeng]

                noFill();
                bezier(85, 20, 10, 10, 90, 90, 15, 80);
                fill(255);
                steps = 10;
                for (var i = 0; i <= steps; i++) {
                    var t = i / steps;
                    x = bezierPoint(85, 10, 90, 15, t);
                    y = bezierPoint(20, 10, 90, 80, t);
                    stroke(100); // this line fix it!
                    ellipse(x, y, 5, 5);
                }

[zenozeng]

Seems that in __applyStyleToCurrentElement, it tries to set strokeStyle to rgba(NaN,NaN,NaN,1),
So, the following code fails:

regex = /rgba\(\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d?\.?\d*)\s*\)/gi;
matches = regex.exec(value);
this.__currentElement.setAttribute(style.svgAttr, format('rgb({r},{g},{b})', {
    r: matches[1],
    g: matches[2],
    b: matches[3]
}));

[zenozeng]

  p5.prototype.stroke = function() {
    this._setProperty('_doStroke', true);
    var ctx = this.drawingContext;
    var color = this.color.apply(this, arguments);
    ctx.strokeStyle = color.toString();
  };
``

[zenozeng]

  p5.prototype.curve = function(x1, y1, x2, y2, x3, y3, x4, y4) {
    if (!this._doStroke) {
      return;
    }
    this.beginShape();
    this.curveVertex(x1, y1);
    this.curveVertex(x2, y2);
    this.curveVertex(x3, y3);
    this.curveVertex(x4, y4);
    this.endShape();
    this.stroke(); // note this line
    return this;
  };

[zenozeng]

It's strange that it call this.stroke() at last, which make current strokeStyle mess.

[zenozeng]

In latest p5.js:

[zenozeng]

However, we should check the behavior of Canvas, and throw a readable exception if try to set strange strokeStyle

[zenozeng]

zenozeng/svgcanvas@2c63508

[zenozeng]

Still having the same bug in 0.4.5, maybe waiting for 0.4.6, there are a lot of commits since 0.4.5.

[zenozeng]

Should be fixed in zenozeng/svgcanvas@9a67300