Giter Site home page Giter Site logo

Comments (13)

aaronyegx avatar aaronyegx commented on June 24, 2024 1

@RichardSWheatley I see you are looking at the issue (maybe another similar ticket) and have some fix in the HAL?

from zephyr.

pillo79 avatar pillo79 commented on June 24, 2024 1

Previous ticket for the same issue: #72775

from zephyr.

aescolar avatar aescolar commented on June 24, 2024 1

Just a question for reference, how come this failure wasn't noticed until months after the hal addition that causes this failure?

The CI run in a PR is a small subset of tests. What tests on what targets is run is based on what files are changed. Sometimes the subset does not cover enough and some issue gets in.
Other PRs which later affect a test may trigger the test being built/run on the affected targets revealing the issue.
The runs in main merge jobs are bigger, but still, do not cover everything. Though when something is detected there it tends to be reported quite soon though.
We also have a weekly job running on a lot of tests x targets combinations, but due to the amount of tests failures are too normal, so only when a pattern is clear it is seen and reported. That is what led to this issue being opened.

from zephyr.

aescolar avatar aescolar commented on June 24, 2024

CC @aaronyegx @AlessandroLuo @RichardSWheatley

from zephyr.

RichardSWheatley avatar RichardSWheatley commented on June 24, 2024

I have an AmbiqHal branch updated to include the folders. Let's speak at Ambiq to determine best path.

from zephyr.

nashif avatar nashif commented on June 24, 2024

I have an AmbiqHal branch updated to include the folders. Let's speak at Ambiq to determine best path.

any updates?

from zephyr.

RichardSWheatley avatar RichardSWheatley commented on June 24, 2024

It's on the list.

from zephyr.

aescolar avatar aescolar commented on June 24, 2024

Lowering priority after the board has been disabled in CI

from zephyr.

RichardSWheatley avatar RichardSWheatley commented on June 24, 2024

Previous ticket for the same issue: #72775

Just a question for reference, how come this failure wasn't noticed until months after the hal addition that causes this failure?

from zephyr.

RichardSWheatley avatar RichardSWheatley commented on June 24, 2024

Just a question for reference, how come this failure wasn't noticed until months after the hal addition that causes this failure?

The CI run in a PR is a small subset of tests. What tests on what targets is run is based on what files are changed. Sometimes the subset does not cover enough and some issue gets in.

Other PRs which later affect a test may trigger the test being built/run on the affected targets revealing the issue.

The runs in main merge jobs are bigger, but still, do not cover everything. Though when something is detected there it tends to be reported quite soon though.

We also have a weekly job running on a lot of tests x targets combinations, but due to the amount of tests failures are too normal, so only when a pattern is clear it is seen and reported. That is what led to this issue being opened.

Did you see the PR my colleague made for this?
It's a short term fix only until we have time to address the issue.

PR #74232

If you approve, I will approve.

from zephyr.

aescolar avatar aescolar commented on June 24, 2024

#74275 ?
That one is not building yet

from zephyr.

RichardSWheatley avatar RichardSWheatley commented on June 24, 2024

#74275 ?

That one is not building yet

They need to add HAL changes to support the kconfig changes.

I am asking about whether that will work for you.

from zephyr.

aescolar avatar aescolar commented on June 24, 2024

I am asking about whether that will work for you.

If the tests pass again, sure. I only disabled it to unblock CI for others.

from zephyr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.