message's std::string ctor is confusing

[zeromq]

message's std::string ctor is confusing

[rodgert]

It is sugar, definitely but not an uncommon usage. I propose
boost::string_ref (std::string_view under '17) as an alternative.

On Monday, September 28, 2015, Andrey Upadyshev [email protected]
wrote:

azmq::message has only a syntax sugar ctor to construct from std::string.
Any other construction from common "buffer representation" (e.g. c-string,
void ptr + size, std::array etc) needs a call of boost::asio::buffer().
This is:

• confusing: different "buffer representations" needs different syntax
  to construct a message from
• non-effective: when user constructs message from c-string, temporary
  std::string is allocated.

I propose either:

1. Remove std::string ctor
2. Add syntax sugar ctors for common "buffer representations", at
   least for the following ones:
   • const void * + size_t
   • c-string

—
Reply to this email directly or view it on GitHub
#113.

[oliora]

Let's add boost::string_ref constructor and remove std::string one then.

std::string_view one may be added later when it became widely available in compilers.

[rodgert]

Agreed. I will add it shortly.

[rodgert]

I may get a chance to do this today, I have immediate use for it.

On Tuesday, September 29, 2015, Andrey Upadyshev [email protected]
wrote:

Let's add boost::string_ref constructor and remove std::string one then.

std::string_view one may be added later when it became widely available
in compilers.

—
Reply to this email directly or view it on GitHub
#113 (comment).